fix: Since the click event does not occur after the touchmove event, set ignoreNextClick to false during touchmove. #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set ignoreNextClick to false during touchmove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2352 #2319.
The following behavior can be reproduced in chrome's smartphone display mode and on the actual device.
When dragging and dropping with the mouse, the click event is executed after the drop. (mousemove)
However, on a smartphone, the click event is not executed after a drop. (touchmove)
Therefore, when fallback is executed on a smartphone, the behavior of pressing a button after a drop is disabled.
To solve this problem, set the ignoreNextClick flag to false for the touchmove event so that the click event is not disabled.
Demo:
https://codepen.io/armdbmfg-the-scripter/pen/NWmLJeL
EventListenerExecutedTimingCheck.mov