Skip to content

Commit

Permalink
Delete deprecated starboard header files (youtube#4106)
Browse files Browse the repository at this point in the history
b/362374622
  • Loading branch information
madhurajayaraman authored Sep 13, 2024
1 parent 6d0800e commit 5a53bcc
Show file tree
Hide file tree
Showing 133 changed files with 6 additions and 971 deletions.
1 change: 0 additions & 1 deletion base/files/file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "base/timer/elapsed_timer.h"
#include "base/trace_event/base_tracing.h"
#include "build/build_config.h"

#if defined(STARBOARD)
#include "starboard/types.h"
#elif BUILDFLAG(IS_POSIX) || BUILDFLAG(IS_FUCHSIA)
Expand Down
1 change: 0 additions & 1 deletion base/files/file_enumerator.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#if defined(STARBOARD)
#include <sys/stat.h>
#include <unistd.h>
#include "starboard/file.h"
#elif BUILDFLAG(IS_WIN)
#include "base/win/windows_types.h"
#elif BUILDFLAG(IS_POSIX) || BUILDFLAG(IS_FUCHSIA)
Expand Down
2 changes: 0 additions & 2 deletions base/files/file_enumerator_starboard.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
#include "starboard/common/log.h"
#include "starboard/common/string.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"
#include "starboard/file.h"
#include "starboard/memory.h"

namespace base {
Expand Down
1 change: 0 additions & 1 deletion base/files/file_starboard.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include "base/strings/stringprintf.h"
#include "base/threading/thread_restrictions.h"
#include "starboard/common/metrics/stats_tracker.h"
#include "starboard/file.h"

namespace base {

Expand Down
1 change: 0 additions & 1 deletion base/files/file_util_starboard.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
#include "base/time/time.h"
#include "starboard/configuration_constants.h"
#include "starboard/common/file.h"
#include "starboard/directory.h"
#include "base/strings/strcat.h"
#include "starboard/system.h"

Expand Down
4 changes: 0 additions & 4 deletions base/files/platform_file.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
#include "base/files/scoped_file.h"
#include "build/build_config.h"

#if defined(STARBOARD)
#include "starboard/file.h"
#endif

#if BUILDFLAG(IS_WIN)
#include "base/win/scoped_handle.h"
#include "base/win/windows_types.h"
Expand Down
1 change: 0 additions & 1 deletion base/files/scoped_file.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "build/build_config.h"

#if defined(STARBOARD)
#include "starboard/file.h"
#include "starboard/types.h"
#include "starboard/common/file.h"
#endif
Expand Down
1 change: 0 additions & 1 deletion base/logging.cc
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
#include "starboard/common/time.h"
#include "starboard/configuration.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"
#include "starboard/system.h"
typedef int* FileHandle;
typedef pthread_mutex_t MutexHandle;
Expand Down
1 change: 0 additions & 1 deletion base/memory/platform_shared_memory_handle.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "base/files/scoped_file.h"
#elif defined(STARBOARD)
#include "base/files/scoped_file.h"
#include "starboard/file.h"
#endif

namespace base::subtle {
Expand Down
2 changes: 0 additions & 2 deletions chrome/updater/util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
#include "crypto/sha2.h"
#include "starboard/configuration_constants.h"
#include "starboard/extension/installation_manager.h"
#include "starboard/file.h"
#include "starboard/string.h"
#include "starboard/system.h"

#define PRODUCT_FULLNAME_STRING "cobalt_updater"
Expand Down
1 change: 0 additions & 1 deletion chrome/updater/utils_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include "base/strings/strcat.h"
#include "base/values.h"
#include "gmock/gmock.h"
#include "starboard/directory.h"
#include "starboard/extension/installation_manager.h"
#include "testing/gtest/include/gtest/gtest.h"

Expand Down
1 change: 0 additions & 1 deletion cobalt/browser/memory_settings/pretty_print_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include "cobalt/browser/memory_settings/test_common.h"
#include "cobalt/browser/switches.h"
#include "starboard/memory.h"
#include "starboard/string.h"
#include "starboard/system.h"
#include "testing/gtest/include/gtest/gtest.h"

Expand Down
1 change: 0 additions & 1 deletion cobalt/browser/memory_settings/table_printer_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "cobalt/browser/memory_settings/table_printer.h"

#include "base/logging.h"
#include "starboard/string.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace cobalt {
Expand Down
1 change: 0 additions & 1 deletion cobalt/browser/splash_screen_cache.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
#include "cobalt/base/get_application_key.h"
#include "starboard/common/string.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"

namespace cobalt {
namespace browser {
Expand Down
1 change: 0 additions & 1 deletion cobalt/cache/memory_capped_directory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/strings/string_number_conversions.h"
#include "starboard/directory.h"

namespace cobalt {
namespace cache {
Expand Down
1 change: 0 additions & 1 deletion cobalt/configuration/configuration.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "base/logging.h"
#include "base/memory/singleton.h"
#include "starboard/common/configuration_defaults.h"
#include "starboard/string.h"
#include "starboard/system.h"

namespace cobalt {
Expand Down
1 change: 0 additions & 1 deletion cobalt/debug/console/command_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include <cstring>

#include "base/logging.h"
#include "starboard/string.h"

namespace cobalt {
namespace debug {
Expand Down
1 change: 0 additions & 1 deletion cobalt/dom/navigator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include "cobalt/web/navigator_base.h"
#include "cobalt/worker/service_worker_container.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"
#include "starboard/media.h"

namespace cobalt {
Expand Down
1 change: 0 additions & 1 deletion cobalt/dom/window.cc
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
#include "cobalt/web/environment_settings_helper.h"
#include "cobalt/web/event.h"
#include "cobalt/web/window_or_worker_global_scope.h"
#include "starboard/file.h"

using cobalt::cssom::ViewportSize;
using cobalt::media_session::MediaSession;
Expand Down
1 change: 0 additions & 1 deletion cobalt/loader/image/jpeg_image_decoder.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "base/callback.h"
#include "cobalt/loader/image/image.h"
#include "cobalt/loader/image/image_data_decoder.h"
#include "starboard/file.h"

// Inhibit C++ name-mangling for libjpeg functions.
extern "C" {
Expand Down
1 change: 0 additions & 1 deletion cobalt/media/sandbox/fuzzer_app.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "base/files/file_util.h"
#include "base/logging.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"

namespace cobalt {
namespace media {
Expand Down
1 change: 0 additions & 1 deletion cobalt/network/dial/dial_system_config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#include "net/base/net_string_util.h"

#if defined(STARBOARD)
#include "starboard/string.h"
#include "starboard/types.h"
#endif

Expand Down
1 change: 0 additions & 1 deletion cobalt/renderer/backend/graphics_context.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#include "base/logging.h"
#include "starboard/gles.h"
#include "starboard/string.h"

namespace cobalt {
namespace renderer {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include "cobalt/renderer/rasterizer/skia/skia/src/ports/SkFreeType_cobalt.h"
#include "cobalt/renderer/rasterizer/skia/skia/src/ports/SkTypeface_cobalt.h"
#include "starboard/extension/font.h"
#include "starboard/string.h"
#include "third_party/icu/source/common/unicode/locid.h"

const char* ROBOTO_SCRIPT = "latn";
Expand Down
1 change: 0 additions & 1 deletion cobalt/script/v8c/isolate_fellowship.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
#include "cobalt/script/v8c/switches.h"
#include "cobalt/script/v8c/v8c_tracing_controller.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"
#include "starboard/memory.h"

namespace cobalt {
Expand Down
1 change: 1 addition & 0 deletions components/update_client/cobalt_slot_management_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "base/time/time.h"
#include "starboard/common/file.h"
#include "starboard/extension/free_space.h"
#include "starboard/file.h"
#include "starboard/loader_app/app_key_files.h"
#include "starboard/loader_app/drain_file.h"
#include "starboard/loader_app/drain_file_helper.h"
Expand Down
3 changes: 0 additions & 3 deletions net/cert/internal/trust_store_in_memory_starboard.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@
#include "net/cert/x509_util.h"
#include "starboard/common/string.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"
#include "starboard/file.h"
#include "starboard/string.h"
#include "third_party/boringssl/src/include/openssl/digest.h"
#include "third_party/boringssl/src/include/openssl/sha.h"
#include "third_party/boringssl/src/include/openssl/x509.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include <unistd.h>

#include "starboard/configuration_constants.h"
#include "starboard/directory.h"
#elif defined(_WIN32)
#include <windows.h>
#else
Expand Down
24 changes: 0 additions & 24 deletions starboard/accessibility.h

This file was deleted.

4 changes: 0 additions & 4 deletions starboard/android/shared/android_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@
#include "starboard/common/file.h"
#include "starboard/common/semaphore.h"
#include "starboard/common/string.h"
#if SB_IS(EVERGREEN_COMPATIBLE)
#include "starboard/directory.h"
#include "starboard/file.h"
#endif
#include "starboard/event.h"
#include "starboard/log.h"
#include "starboard/shared/starboard/command_line.h"
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/file_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

#include <android/asset_manager.h>

#include "starboard/file.h"
#include "starboard/shared/internal_only.h"

struct SbFilePrivate {
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/media_is_supported.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "starboard/android/shared/media_common.h"
#include "starboard/media.h"
#include "starboard/shared/starboard/media/mime_type.h"
#include "starboard/string.h"

bool SbMediaIsSupported(SbMediaVideoCodec video_codec,
SbMediaAudioCodec audio_codec,
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/player_create.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
#include "starboard/shared/starboard/player/filter/filter_based_player_worker_handler.h"
#include "starboard/shared/starboard/player/player_internal.h"
#include "starboard/shared/starboard/player/player_worker.h"
#include "starboard/string.h"

using starboard::shared::starboard::player::PlayerWorker;
using starboard::shared::starboard::player::filter::
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "starboard/configuration.h"
#include "starboard/shared/starboard/media/media_util.h"
#include "starboard/shared/starboard/player/filter/player_components.h"
#include "starboard/string.h"

SbPlayerOutputMode SbPlayerGetPreferredOutputMode(
const SbPlayerCreationParam* creation_param) {
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/posix_emu/file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "starboard/android/shared/file_internal.h"
#include "starboard/common/log.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"
#include "starboard/log.h"

using starboard::android::shared::AssetManager;
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/posix_emu/stat.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

#include "starboard/android/shared/file_internal.h"
#include "starboard/common/log.h"
#include "starboard/directory.h"

using starboard::android::shared::IsAndroidAssetPath;
using starboard::android::shared::OpenAndroidAsset;
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/system_get_path.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "starboard/android/shared/file_internal.h"
#include "starboard/common/log.h"
#include "starboard/common/string.h"
#include "starboard/directory.h"

#if SB_IS(EVERGREEN_COMPATIBLE)
#include "starboard/elf_loader/evergreen_config.h" // nogncheck
Expand Down
1 change: 0 additions & 1 deletion starboard/android/shared/video_decoder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
#include "starboard/memory.h"
#include "starboard/shared/starboard/media/mime_type.h"
#include "starboard/shared/starboard/player/filter/video_frame_internal.h"
#include "starboard/string.h"
#include "starboard/thread.h"

namespace starboard {
Expand Down
25 changes: 0 additions & 25 deletions starboard/byte_swap.h

This file was deleted.

1 change: 0 additions & 1 deletion starboard/client_porting/icu_init/icu_init.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include "starboard/common/once.h"
#include "starboard/configuration.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"
#include "starboard/system.h"
#include "third_party/icu/source/common/unicode/putil.h"
#include "third_party/icu/source/common/unicode/udata.h"
Expand Down
1 change: 0 additions & 1 deletion starboard/common/condition_variable.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include <pthread.h>

#include "starboard/common/mutex.h"
#include "starboard/condition_variable.h"
#include "starboard/configuration.h"
#include "starboard/types.h"

Expand Down
1 change: 0 additions & 1 deletion starboard/common/experimental/concurrency_debug.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "starboard/common/log.h"
#include "starboard/common/time.h"
#include "starboard/configuration_constants.h"
#include "starboard/mutex.h"
#include "starboard/thread.h"

// WARNING: Features inside experimental namespace is strictly experimental and
Expand Down
4 changes: 0 additions & 4 deletions starboard/common/file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@
#include "starboard/common/metrics/stats_tracker.h"
#include "starboard/common/string.h"
#include "starboard/configuration_constants.h"
#include "starboard/directory.h"
#include "starboard/file.h"
#include "starboard/shared/starboard/file_atomic_replace_write_file.h"
#include "starboard/string.h"

namespace starboard {
namespace {
Expand Down
1 change: 0 additions & 1 deletion starboard/common/paths.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include <vector>
#include "starboard/common/log.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"
#include "starboard/system.h"

namespace starboard {
Expand Down
Loading

0 comments on commit 5a53bcc

Please sign in to comment.