Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the column 'Params %' #199

Merged
merged 5 commits into from
Nov 28, 2022
Merged

Add the column 'Params %' #199

merged 5 commits into from
Nov 28, 2022

Conversation

luke396
Copy link
Contributor

@luke396 luke396 commented Nov 23, 2022

To fix Idea: add the column "Params %" in addition to "Params #" · Issue #159

I am still a newbie and would like to get any advice and guidance!

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #199 (924d118) into main (c871c3a) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   97.47%   97.52%   +0.05%     
==========================================
  Files           6        6              
  Lines         594      607      +13     
==========================================
+ Hits          579      592      +13     
  Misses         15       15              
Impacted Files Coverage Δ
torchinfo/torchinfo.py 97.35% <ø> (ø)
torchinfo/enums.py 100.00% <100.00%> (ø)
torchinfo/formatting.py 100.00% <100.00%> (ø)
torchinfo/layer_info.py 96.09% <100.00%> (+0.22%) ⬆️
torchinfo/model_statistics.py 98.52% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

torchinfo/enums.py Outdated Show resolved Hide resolved
torchinfo/formatting.py Outdated Show resolved Hide resolved
tests/test_output/basic_per_summary.out Outdated Show resolved Hide resolved
@TylerYep
Copy link
Owner

Thanks for the PR! I suggested some alternatives to simplify the changes

torchinfo/layer_info.py Outdated Show resolved Hide resolved
@TylerYep
Copy link
Owner

Made some tweaks to have the calculations match and also right-justified the text so it looks nicer. Otherwise looks good, thanks for the contribution!

@TylerYep TylerYep merged commit 985023a into TylerYep:main Nov 28, 2022
@luke396 luke396 deleted the tmp branch November 28, 2022 09:26
@luke396
Copy link
Contributor Author

luke396 commented Nov 28, 2022

@TylerYep, Thanks your review a lot! I read your code implementation and learned a lot. My superficial attempts do have a lot of problems. If you don't mind, I will continue to try to solve issues and make PR in the future.

@TylerYep
Copy link
Owner

That would be great! All contributions are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: add the column "Params %" in addition to "Params #"
2 participants