-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the column 'Params %' #199
Conversation
Codecov Report
@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 97.47% 97.52% +0.05%
==========================================
Files 6 6
Lines 594 607 +13
==========================================
+ Hits 579 592 +13
Misses 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks for the PR! I suggested some alternatives to simplify the changes |
Made some tweaks to have the calculations match and also right-justified the text so it looks nicer. Otherwise looks good, thanks for the contribution! |
@TylerYep, Thanks your review a lot! I read your code implementation and learned a lot. My superficial attempts do have a lot of problems. If you don't mind, I will continue to try to solve issues and make PR in the future. |
That would be great! All contributions are welcome :) |
To fix Idea: add the column "Params %" in addition to "Params #" · Issue #159
I am still a newbie and would like to get any advice and guidance!