Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain reportEvent to custom destination urls (with macro substitution) #763

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Explain reportEvent to custom destination urls (with macro substitution) #763

merged 8 commits into from
Oct 24, 2023

Conversation

gtanzer
Copy link
Contributor

@gtanzer gtanzer commented Aug 21, 2023

No description provided.

JensenPaul
JensenPaul reviewed Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@JensenPaul JensenPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivanigithub, can you please review?

Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
shivanigithub
shivanigithub reviewed Sep 14, 2023
View reviewed changes
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Show resolved Hide resolved
shivanigithub
shivanigithub reviewed Sep 14, 2023
View reviewed changes
Fenced_Frames_Ads_Reporting.md Show resolved Hide resolved
Fenced_Frames_Ads_Reporting.md Outdated Show resolved Hide resolved
shivanigithub
shivanigithub approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@shivanigithub shivanigithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % typo

@shivanigithub
Copy link
Contributor

@shivanigithub, can you please review?

completed, thanks!

@gtanzer
Copy link
Contributor Author

gtanzer commented Oct 23, 2023

@JensenPaul Can we merge this?

@JensenPaul JensenPaul merged commit 919f106 into WICG:main Oct 24, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Oct 24, 2023
@gtanzer @github-actions
Explain reportEvent to custom destination urls (with macro substituti…
8520a6b 
…on) (#763)

SHA: 919f106
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@blu25 blu25 mentioned this pull request Apr 16, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JensenPaul JensenPaul JensenPaul left review comments

@shivanigithub shivanigithub shivanigithub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtanzer @shivanigithub @JensenPaul