Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout animation regression introduced in 4.3.0 #2194

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

calda
Copy link
Member

@calda calda commented Sep 18, 2023

This PR fixes a regression introduced by #2183 where the frame of the animation layer could unexpectedly animate.

I don't have repro steps for this, but I worked with @aureliencolas to identify the change that introduced the regression: #2193 (comment)

#2183 added a display() call to CoreAnimationLayer.forceDisplayUpdate(), which appears to be the culprit here. We can revert that change and implement the behavior needed for those tests a different way.

Here's a gif from the issue showing the regression, which is fixed by this change:

@calda
Copy link
Member Author

calda commented Sep 19, 2023

ptal @thedrick

Copy link
Contributor

@miguel-jimenez-0529 miguel-jimenez-0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calda calda merged commit 01a3ac1 into master Sep 20, 2023
17 checks passed
@calda calda deleted the cal--fix-forceDisplayUpdate-regression branch September 20, 2023 18:24
iago849 pushed a commit to atteamapps/lottie-ios that referenced this pull request Feb 8, 2024
iago849 pushed a commit to atteamapps/lottie-ios that referenced this pull request Feb 8, 2024
MoroziOS pushed a commit to MoroziOS/tmg-lottie-ios that referenced this pull request May 22, 2024
MoroziOS pushed a commit to MoroziOS/tmg-lottie-ios that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants