Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Google example DAG s3_to_gcs to new design AIP-47 #24641

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Migrate Google example DAG s3_to_gcs to new design AIP-47 #24641

merged 1 commit into from
Jun 28, 2022

Conversation

chenglongyan
Copy link
Contributor

related: #22447, #22430


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Jun 26, 2022

Rebased to fix selective check problem from #24665 after it's merged.

Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look functionally fine, but there are some formatting issues that are causing static checks to fail.

You can check for these on your local dev machine easily by enabling pre commit/push checks (see the airflow docs here and here on how to do that)

@potiuk potiuk merged commit 7a7ca50 into apache:main Jun 28, 2022
@eladkal eladkal mentioned this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants