Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type hint causing DeprecationWarning in Firestore operators #9819

Merged
merged 2 commits into from
Jul 21, 2020

Conversation

turbaszek
Copy link
Member

DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated since Python 3.3,
and in 3.9 it will stop working


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated since Python 3.3,
and in 3.9 it will stop working
@turbaszek turbaszek requested a review from mik-laj July 14, 2020 12:57
@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Jul 14, 2020
@turbaszek turbaszek changed the title Import Iterable from collections.abc in firestore operators Remove redundant type hint causing DeprecationWarning Jul 20, 2020
@turbaszek turbaszek changed the title Remove redundant type hint causing DeprecationWarning Remove type hint causing DeprecationWarning in Firestore operators Jul 20, 2020
@potiuk potiuk merged commit c8c52e6 into apache:master Jul 21, 2020
@potiuk potiuk deleted the abc-firestore-warning branch July 21, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants