Fix issue with allocator not considering subsequent clusters

[Pearl1594]

Description

This PR fixes: #10598
While #8611 seems to have fixed this issue in 4.19.1, I believe it got lost in the process of resolving merge conflicts / forward merging into 4.20.0.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 16.01%. Comparing base (653b973) to head (0977c5c).
Report is 2 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../agent/manager/allocator/impl/RandomAllocator.java	0.00%	6 Missing ⚠️
...gent/manager/allocator/impl/FirstFitAllocator.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10603   +/-   ##
=========================================
  Coverage     16.00%   16.01%           
- Complexity    13104    13118   +14     
=========================================
  Files          5651     5651           
  Lines        495870   495895   +25     
  Branches      60049    60057    +8     
=========================================
+ Hits          79370    79422   +52     
+ Misses       407638   407617   -21     
+ Partials       8862     8856    -6     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	16.85% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

oh, check-style error

Error:  /home/runner/work/cloudstack/cloudstack/server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java:28:8: Unused import - com.cloud.utils.exception.CloudRuntimeException. [UnusedImports]

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12856

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-12800)

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12801)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58506 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10603-t12801-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_restore_vm_strict_tags_failure	Failure	56.38	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	Failure	64.69	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	Failure	5.64	test_vm_strict_host_tags.py

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[shwstppr]

Code LGTM

[weizhouapache]

code lgtm

[DaanHoogland]

clgtm

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12905

[Pearl1594]

@blueorangutan test

[blueorangutan]

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12847)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56306 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10603-t12847-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_restore_vm_strict_tags_failure	Failure	53.37	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	Failure	54.44	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	Failure	5.72	test_vm_strict_host_tags.py