Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.apache.commons:commons-compress to v1.22 #1415

Conversation

solrbot
Copy link
Collaborator

@solrbot solrbot commented Mar 1, 2023

This PR contains the following updates:

Package Type Update Change
org.apache.commons:commons-compress (source) dependencies minor 1.21 -> 1.22

Configuration

📅 Schedule: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot

@janhoy
Copy link
Contributor

janhoy commented Mar 1, 2023

I believe this is another case where we could remove this line from versions.props. After removing, precommit passes and for "why" I get:

> Task :why
org.apache.commons:commons-compress:1.21
	org.apache.poi:poi-ooxml -> 1.21
	org.apache.tika:tika-parsers -> 1.21

@risdenk
Copy link
Contributor

risdenk commented Mar 2, 2023

At least from a quick git grep commons-compress in build.gradle:

solr/modules/hdfs/build.gradle:  testImplementation 'org.apache.commons:commons-compress'

so I think we do reference it. I guess because its a test then its not found - which is super surprising. Either way it might be possible we can remove that usage from tests - I haven't looked.

@risdenk
Copy link
Contributor

risdenk commented Mar 2, 2023

It is used in solr/modules/hdfs/src/test/org/apache/hadoop/fs/FileUtil.java which is part of Hadoop code for testing. We copied it in to avoid security manager issues.

@risdenk risdenk merged commit 49d41b7 into apache:main Mar 2, 2023
@solrbot solrbot deleted the renovate/org.apache.commons-commons-compress-1.x branch March 2, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants