Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: Set a more informative html title #626

Closed
llllvvuu opened this issue May 15, 2023 · 2 comments · Fixed by #655
Closed

web: Set a more informative html title #626

llllvvuu opened this issue May 15, 2023 · 2 comments · Fixed by #655
Labels
feature-request A request for a new feature x:planned We're on it!

Comments

@llllvvuu
Copy link
Contributor

Is your feature request related to a problem? Please describe.

"Profile" is not a very informative title when looking at my tabs.

Describe the solution you'd like

See Twitter: "($NUM_NOTIFS) $NAME ($HANDLE) / Twitter"

Describe alternatives you've considered

N/A

Additional context

I would probably be able to implement this if people think it's a good idea.
@llllvvuu llllvvuu added the feature-request A request for a new feature label May 15, 2023
@llllvvuu llllvvuu changed the title Set a more informative html title web: Set a more informative html title May 15, 2023
@bnewbold
Copy link
Contributor

See also #599 which has some context and a reference link. That task was moved to an internal issue tracker.

@llllvvuu
Copy link
Contributor Author

Thanks for the reference! Just gave it a shot: #655

llllvvuu added a commit to llllvvuu/social-app that referenced this issue May 16, 2023
@llllvvuu
feat: Update HTML title on web bluesky-social#626 bluesky-social#599
6be70bf 
For any `Screen` that shows on desktop, `title` is "(1) ... - Bluesky"
where "(1)" is the unread notification count.

The titles are unlocalized and the string "Bluesky" is hardcoded,
following the pattern in the rest of the app.

Display names and post content are loaded into the title as effects.

New utilities: `useUnreadCountLabel`, `bskyTitle`,
`combinedDisplayName`, `useSetTitle`.
@llllvvuu llllvvuu mentioned this issue May 16, 2023
Merged
llllvvuu added a commit to llllvvuu/social-app that referenced this issue May 16, 2023
@llllvvuu
feat: Update HTML title on web bluesky-social#626 bluesky-social#599
b35f0f9 
For any `Screen` that shows on desktop, `title` is "(1) ... - Bluesky"
where "(1)" is the unread notification count.

The titles are unlocalized and the string "Bluesky" is hardcoded,
following the pattern in the rest of the app.

Display names and post content are loaded into the title as effects.

New utilities: `useUnreadCountLabel`, `bskyTitle`,
`combinedDisplayName`, `useSetTitle`.
llllvvuu added a commit to llllvvuu/social-app that referenced this issue May 16, 2023
@llllvvuu
feat: Update HTML title on web bluesky-social#626 bluesky-social#599
0e08319 
For any `Screen` that shows on desktop, `title` is "(1) ... - Bluesky"
where "(1)" is the unread notification count.

The titles are unlocalized and the string "Bluesky" is hardcoded,
following the pattern of the rest of the app.

Display names and post content are loaded into the title as effects.

Tested:
* all screens
* screen changes / component mounts/unmounts
* long posts with links and images
* display name set/unset
* spamming myself with notifications, clearing notifications
* /profile/did:... links
* lint (only my changed files), jest, e2e.

New utilities: `useUnreadCountLabel`, `bskyTitle`,
`combinedDisplayName`, `useSetTitle`.

resolves: bluesky-social#626 bluesky-social#599
@pfrazee pfrazee added the x:planned We're on it! label May 16, 2023
pfrazee pushed a commit that referenced this issue May 16, 2023
@llllvvuu
feat: Update HTML title on web #626 #599 (#655)
50c1841 
For any `Screen` that shows on desktop, `title` is "(1) ... - Bluesky"
where "(1)" is the unread notification count.

The titles are unlocalized and the string "Bluesky" is hardcoded,
following the pattern of the rest of the app.

Display names and post content are loaded into the title as effects.

Tested:
* all screens
* screen changes / component mounts/unmounts
* long posts with links and images
* display name set/unset
* spamming myself with notifications, clearing notifications
* /profile/did:... links
* lint (only my changed files), jest, e2e.

New utilities: `useUnreadCountLabel`, `bskyTitle`,
`combinedDisplayName`, `useSetTitle`.

resolves: #626 #599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A request for a new feature x:planned We're on it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Update HTML title on web (resolve #626 #599) llllvvuu/social-app
3 participants
@bnewbold @pfrazee @llllvvuu