Close active elements on state change #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just noticing that the back browser navigation wasn't working properly! I have no idea if this PR works but nice! |
|
@classicrob here's a happy path GIF. That said, this PR does not address that modals and lightboxes do not have routes tied to them. I linked the corresponding documentation which should help the team get there moving forward.
|
pfrazee
approved these changes
May 17, 2023
aarongustafson
pushed a commit
to aarongustafson/social-app
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR:
Known issues:
beforeRemoveevent not fired on browser back buttonreact-navigationinto the codebase, hence going back from a modal does not return the user to what is, by their definition, the previous screen. This is likely the desired approach moving forward but the changes in this PR are sufficient for now.