Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic visual feedback on Button interactions #708

Merged
merged 4 commits into from
May 17, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented May 17, 2023

Supercedes #701

Adds visual feedback to the hover & press state of buttons. This PR uses a single callback instead of a state hook which should be a little more efficient.

@pfrazee pfrazee merged commit 562faa7 into main May 17, 2023
@pfrazee pfrazee deleted the Simek-@simek/basic-button-interaction-feedback branch May 17, 2023 16:10
aarongustafson pushed a commit to aarongustafson/social-app that referenced this pull request May 18, 2023
…l#708)

* feat: add basic visual feedback on Button interaction

* Use a more efficient approach to providing visual feedback

* Fix some lint issues left over from another PR

---------

Co-authored-by: Simek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants