Remove deprecated metadata #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thommay
force-pushed
the
tm/remove_metadata
branch
from
5cab7cd
to
dd37b14
Compare
marcparadise
approved these changes
Apr 3, 2017
Signed-off-by: Thom May <[email protected]>
thommay
force-pushed
the
tm/remove_metadata
branch
from
dd37b14
to
1ccdb9b
Compare
|
@marcparadise rebased |
stevendanna
approved these changes
Apr 3, 2017
There was a problem hiding this comment.
This looks good to me. While we are removing some tests, it is functionality that was never really used by the client and the server will still be sending the same content for the moment. If we do ever decide to filter out these older metadata keys, we'll need to bump the API version and we can add tests around that behavior at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.