[pedant] Wait for rabbitmq before every search test #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search index in eventually consistent but the test code treats it as if it were read-after-write consistent. To mitigate this we wait for the indexing queue to be empty before executing a search test. This is going to slow these tests down, but we are trying to stabilize the tests first. Signed-off-by: Steven Danna <[email protected]>
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search index is eventually consistent but the test code treats it
as if it were read-after-write consistent.
To mitigate this we wait for the indexing queue to be empty before
executing a search test.
This is going to slow these tests down, but we are trying to stabilize
the tests first.
Signed-off-by: Steven Danna [email protected]