Parameterize the search_server in the habitized pedant config #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymv2
approved these changes
Feb 14, 2019
Signed-off-by: Irving Popovetsky <[email protected]>
irvingpop
force-pushed
the
irving/fix-pedant-es-direct-access-in-hab
branch
from
4327058
to
016ce69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Irving Popovetsky [email protected]
Description
In certain tests pedant wants to directly access the Solr/Elasticsearch, but binding to it will create circular binds, which we want avoid.
The compromise is to allow users to specify the ES URL directly, but if they don't it's no big deal because it is just for the pedant test suite.
Check List