Add a 'detail=granular' query option to GET ACL endpoint #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note chef-zero failures are expected for a bit longer, until updated for the API change this afternoon. |
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
41f16ec
to
f80e3ab
Compare
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
f80e3ab
to
a73a424
Compare
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
a73a424
to
69164dd
Compare
marcparadise
force-pushed
the
SPOOL-197-clients-users-for-acl
branch
from
a9f35d1
to
8cdd30a
Compare
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
69164dd
to
44e4101
Compare
| @@ -75,7 +75,7 @@ matrix: | |||
| before_script: cd oc-chef-pedant | |||
| script: bundle exec rake chef_zero_spec | |||
| env: | |||
| - "GEMFILE_MOD=\"gem 'rake'; gem 'chef-zero', github: 'chef/chef-zero'\"" | |||
| - "GEMFILE_MOD=\"gem 'rake'; gem 'chef-zero', github: 'chef/chef-zero', branch: 'mp/SPOOL-340' \"" | |||
There was a problem hiding this comment.
Should we wait to merge until this PR gets merged in?
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
44e4101
to
651d800
Compare
marcparadise
changed the base branch from
SPOOL-197-clients-users-for-acl
to
master
|
One potential refactor, but other than that 👍 We've needed this forever lol. |
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
d5183e3
to
444920c
Compare
| @@ -204,14 +205,16 @@ fetch_cookbook_id(DbContext, Name, OrgId) -> | |||
| AuthzId | |||
| end. | |||
|
|
|||
| -spec fetch(chef_type(), id()) -> list() | {error, term()}. | |||
There was a problem hiding this comment.
Shouldn't this spec be retained?
|
👍 |
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
444920c
to
281c74b
Compare
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
281c74b
to
ace8b6b
Compare
added 2 commits
September 2, 2016 13:51
… acl body Signed-off-by: Marc Paradise <[email protected]>
When specified, this option will split out users and clients within the body response, and will force 'actors' to be empty. This body response is compatible with re-PUTing the body back to the object ACE endpoint as-is, which will simplify changes to tooling when updating it to use recently-added new ACL endpoint functionality. Signed-off-by: Marc Paradise <[email protected]>
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
ace8b6b
to
e0c360c
Compare
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
e0c360c
to
1c7c236
Compare
| * 400 responses in object ACL updates will now include the specific | ||
| missing or incorrect entities where appropriate. | ||
|
|
||
| * The GET | ||
| The GET API response for object ACL has not been changed by default, |
There was a problem hiding this comment.
Duplicate line? Looks weird...
|
Other than the odd line in the release notes file, 👍 |
Signed-off-by: Marc Paradise <[email protected]>
marcparadise
force-pushed
the
SPOOL-340/granular-object-acl-get
branch
from
1c7c236
to
3153f27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specified, this option will split out users and clients within
the body response, and will force 'actors' to be empty. This body
response is compatible with re-PUTing the body back to the object ACE
endpoint as-is, which will simplify changes to tooling when updating it
to use recently-added new ACL endpoint functionality.
Pre-merge:
.travis.ymlto master of chef-zero