Do not fail complete reindex when one object fails #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcparadise
requested changes
Oct 11, 2016
| %% Since we get here via valid `Index', we don't have to check that the objects are | ||
| %% indexable. | ||
| oc_chef_object_db:add_to_solr_async(StubRec, PreliminaryEJson), | ||
| []; |
There was a problem hiding this comment.
This should be the unmodified MissingList getting returned - otherwise we empty our existing list
There was a problem hiding this comment.
Fixed in latest commit.
smith
force-pushed
the
nls/SPOOL-388/reindex-continue
branch
2 times, most recently
from
57900d8
to
2a16cab
Compare
There are cases when we do a reindex where the object name in the serialized JSON does not match the name we get when selecting `(id, name)` from the database. Currently when this lookup fails, the entire reindex crashes. This change makes it so that if we fail to find the name, instead of failing entirely, we output a list of objects that failed to reindex to the user. Signed-off-by: Nathan L Smith <[email protected]>
smith
force-pushed
the
nls/SPOOL-388/reindex-continue
branch
from
2a16cab
to
1d68f9a
Compare
marcparadise
approved these changes
Oct 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases when we do a reindex where the object name in the
serialized JSON does not match the name we get when selecting
(id, name)fromthe database.
Currently when this lookup fails, the entire reindex crashes. This
change makes it so that if we fail to find the name, instead of failing
entirely, we output a list of objects that failed to reindex to the
user.