Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_cli] Rename package:hook to package:hooks #2136

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

dcharkes
Copy link
Collaborator

Bug: #999

A package name is either a verb, a singular noun, or a plural noun. Since this package name is a noun and there is more than one hook (build hook and link hook), rename the package to a plural noun.

@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:native_assets_cli labels Mar 26, 2025
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes force-pushed the undo-manual-sorting branch from aec0498 to 99af41e Compare March 26, 2025 07:53
@dcharkes dcharkes force-pushed the rename-package-hook branch from ba29ea4 to abe3f71 Compare March 26, 2025 07:53
Copy link
Member

@mosuem mosuem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I assume the name is free or can be freed on pub.dev)

@dcharkes dcharkes force-pushed the undo-manual-sorting branch from 99af41e to 106c355 Compare March 26, 2025 17:41
Base automatically changed from undo-manual-sorting to main March 26, 2025 17:51
@dcharkes dcharkes force-pushed the rename-package-hook branch from abe3f71 to 037b00a Compare March 26, 2025 17:52
@dcharkes dcharkes force-pushed the rename-package-hook branch from 037b00a to 5fe2513 Compare March 26, 2025 21:06
@auto-submit auto-submit bot merged commit af29d98 into main Mar 26, 2025
46 checks passed
@auto-submit auto-submit bot deleted the rename-package-hook branch March 26, 2025 21:18
@coveralls
Copy link

Coverage Status

coverage: 85.954%. remained the same
when pulling 5fe2513 on rename-package-hook
into 540e669 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit package:native_assets_cli type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants