Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display HTML links when current search has no results and adding another filter wouldn't add more. #8662

Closed
wants to merge 1 commit into from

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Mar 21, 2025

  • Similarly to Hide sort control when there is no result to be sorted. #8661, reduces the link surface, so indiscriminate crawlers have fewer things to request from us.
  • The complexity comes from is:unlisted, as it is not restricting, rather expanding the result set, so we need to pass the appropriate information down as well.
  • The web app's dynamic update is also adjusted to work with the <span> as well as the <a> element.

@isoos isoos requested review from jonasfj and sigurdm March 21, 2025 15:03
@isoos
Copy link
Collaborator Author

isoos commented Mar 21, 2025

Note: pushed to staging for further testing.

@isoos
Copy link
Collaborator Author

isoos commented Mar 25, 2025

Offline discussion prompted to put a bit more effort into the index before removing these links, closing for now (#8670, #8671).

@isoos isoos closed this Mar 25, 2025
@isoos isoos deleted the search-form-links branch March 25, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant