Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 18298 - add note about frozen curl package #6116

Closed
wants to merge 1 commit into from

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Feb 3, 2018

I think this is the third time I have the same issue on the issue tracker and I don't know how many times people have been having asking for a better http client on the forums.
This PR makes the standard answer: "No one is or will be working on that. However, try requests it's great, written entirely in D, compatible with Vibe.d eventloop for async requests and as fast as curl"

See also:

The author of D's requests package shares a similar opinion as the Python requests developer have:

Essentially, the standard library is where a library goes to die.
It is appropriate for a module to be included when active
development is no longer necessary.

psf/requests#2424
http://docs.python-requests.org/en/latest/dev/philosophy/

With the web consistently moving (HTTP/2, newer SSL releases, etc.),
it's unlikely that the development will stop.

Hence, my proposal is to state the facts and to prevent people from bumping into the same issue over and over again.

Preview:

image

@wilzbach wilzbach requested a review from CyberShadow as a code owner February 3, 2018 15:23
@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 3, 2018

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Description
18298 curl high level form wrapper

@CyberShadow
Copy link
Member

I don't understand. What makes std.net.curl different than any other Phobos module (except for std.experimental) in this regard?

I don't see the point in this change.

@CyberShadow
Copy link
Member

CyberShadow commented Feb 3, 2018

Instead of passing judgement, one thing we could do is add some links to some established Dub repositories, e.g. "Similar packages on code.dlang.org: (list of packages)" or just a link to "Browse similar packages on code.dlang.org".

Ideally such lists would be automatically generated - filtered by topic and sorted by popularity, but doing it manually could be fine for now.

In any case, this is up to @andralex. I suspect he won't like the change in this PR either, but maybe we could discuss something along the lines of the above.

@wilzbach
Copy link
Member Author

wilzbach commented Feb 3, 2018

What makes std.net.curl different than any other Phobos module (except for std.experimental) in this regard?

No active development, but people expect a lot of functionality from it.

I don't see the point in this change.

That I'm tired of explaining to people that std.net.curl isn't under development and that requests is to the go to alternative.

@CyberShadow
Copy link
Member

CyberShadow commented Feb 3, 2018

No active development, but people expect a lot of functionality from it.

cURL itself is actively developed.

What's missing from std.net.curl? Shouldn't any new cURL functionality not be hard to wrap?

@CyberShadow
Copy link
Member

CyberShadow commented Feb 3, 2018

No active development, but people expect a lot of functionality from it.

I don't understand how it has any less active development than the rest of Phobos. It receives periodic pull requests, like all Phobos modules, does it not?

@JackStouffer
Copy link
Member

I'm going to have to agree with @CyberShadow here and echo the comments made by Andrei and Johnathan here: #5637

If you feel strongly about this, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants