Windows Installer: Added ability to detect and uninstall existing installations when detected #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when installing PlotJuggler, the installer simply fails when an existing installation is present. This modification to the Qt Installer Framework installer is based on StackOverflow answers by rationalcoder, Skeird, and chipolux addressing this use-case of Qt Installer Framework's offline installer.
When an existing installation is detected, the installer now merely displays a message stating "Existing installation detected and will be overwritten". By calling the
maintenancetool.exe, the installation is not merely overwritten, but the previous installation is properly uninstalled, too.