Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Store rejecting binaries due to Non-public API usage #8222

Closed
Alexsilvacodes opened this issue Jun 10, 2021 · 8 comments · Fixed by #8233
Closed

App Store rejecting binaries due to Non-public API usage #8222

Alexsilvacodes opened this issue Jun 10, 2021 · 8 comments · Fixed by #8233
Assignees
Labels
api: analytics beta-software Related to using beta iOS or Xcode versions. Xcode 13 - iOS 15

Comments

@Alexsilvacodes
Copy link

Alexsilvacodes commented Jun 10, 2021

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 12.5
  • Firebase SDK version: 8.1.0 / 7.11.0
  • Installation method: Swift Package Manager
  • Firebase Component: Analytics / Crashlytics / RemoteConfig - not 100% sure

[REQUIRED] Step 2: Describe the problem

We are using Firebase Analytics, RemoteConfig and Crashlytics importing this SDK via SPM, since two days ago our binaries are getting rejected by Apple with the following message

ITMS-90338: Non-public API usage - The app references non-public selectors in <app>: determineAppInstallationAttributionWithCompletionHandler:, didLongPress:, didPan:, didTap, didTouchUpInside, lookupAdConversionDetails:, resetState, sendMessage, textDidChange, transform:.

Our app doesn't use any of those methods, but checking our symbolmap we discovered that Firebase SDK is using the method lookUpAdConversionDetails.
We are having this issues without changing any dependency version or Xcode configuration, so looks like Apple changed their API-usage process.

We are investigating if this is an Apple issue or is something that Firebase should take action on, if you can provide more info about this it will be much appreciated.

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@ryanwilson
Copy link
Member

Hey @Alexsilvacodes - thanks for the report. We'll look into this ASAP to get it resolved. At first glance, it looks like this it was a public API that was deprecated and is now removed from the public headers in iOS 15.

@ryanwilson ryanwilson added the beta-software Related to using beta iOS or Xcode versions. label Jun 10, 2021
@ryanwilson
Copy link
Member

Filed internally at b/190661518. Note: for the beta-software label it's to acknowledge this is due to iOS 15 changes, I recognize that this happens still with publicly released versions.

@Alexsilvacodes
Copy link
Author

Hi @ryanwilson, thank you for your quick response! Right now we are not using anything related with iOS 15, our target is iOS 14 and in fact we got this using Firebase 7.11.0, then we tried 8.1.0 just to see if there was any change on the SDK to fix that.

@ryanwilson
Copy link
Member

ryanwilson commented Jun 10, 2021

Thanks @Alexsilvacodes, this is definitely a change on the App Store side (or a flake, but it seems unlikely). My suspicion is they now updated the "private APIs" list, and since the API being used was in a public header before and removed, it's now on the private API list and being flagged (regardless if you're supporting any iOS 15 features or not).

We'll hopefully have another update in a few hours, a lot of the team is in California so it's still quite early there before they'll see this and we can evaluate the impact. Stay tuned, and thanks again for the report.

@Alexsilvacodes
Copy link
Author

Amazing @ryanwilson , thank you so much for the quick and thoughtful response!

@paulb777
Copy link
Member

Firebase 8.1.1 is now published for CocoaPods and Swift Package Manager. The zip and Carthage distributions are planned to be updated tomorrow (Friday)

@paulb777
Copy link
Member

8.1.1 is now available for zip and Carthage distributions as well.

mikehardy added a commit to invertase/react-native-firebase that referenced this issue Jun 11, 2021
…8.1.1

Very important on the firebase-ios-sdk to avoid App Store Rejection:
firebase/firebase-ios-sdk#8222
mikehardy added a commit to invertase/react-native-firebase that referenced this issue Jun 11, 2021
…8.1.1

Very important on the firebase-ios-sdk to avoid App Store Rejection:
firebase/firebase-ios-sdk#8222
mikehardy added a commit to invertase/react-native-firebase that referenced this issue Jun 11, 2021
…8.1.1

Very important on the firebase-ios-sdk to avoid App Store Rejection:
firebase/firebase-ios-sdk#8222
@firebase firebase locked and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: analytics beta-software Related to using beta iOS or Xcode versions. Xcode 13 - iOS 15
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants