Major bump for database-compat for Node engines change. #8586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: df819ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsNo changes between base commit (a97ac88) and merge commit (11d60fd).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (a97ac88) and merge commit (11d60fd).Test Logs |
DellaBitta
approved these changes
Oct 22, 2024
dlarocque
approved these changes
Oct 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8583
In order to mark the Node
enginesrequirement change with a major bump, we need to do two steps:database-compatbumped by a major version to 2.0.0, which contains the Nodeenginesrequirement of 18.0.0 to enable current web SDK users to not be disrupted by the next step@firebase/database-compatwithin the 1.x.x version range which reverts theenginesfield change (has no engines field, as it did before 11.0.0), enabling any repos with a semver^1.x.xdependency on@firebase/database-compatto avoid receiving theenginesfield bump.