-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tentative] Adding 192 head dim (step_size = 12) #454
base: main
Are you sure you want to change the base?
Conversation
@Narsil May you write unit test for it? And you can ref https://github.com/zhyncs/dl/blob/master/flashinfer_build.sh to compile from source. |
Which tests would you like me to add, batch_prefill_kernels ? others ? Wdym ref to build from source ? I am building already. |
https://github.com/flashinfer-ai/flashinfer/blob/main/python/tests/test_batch_prefill_kernels.py
ok |
Are the tests ran anywhere ? |
There is currently no CI configured, you can use pytest in the local development environment to run. |
Hi @Narsil , thanks for your contribution! Line 67 in 0d61871
if compilation successes, you can run unittests such as https://github.com/flashinfer-ai/flashinfer/blob/0d618712faff20a84bbd513d02ac01e16be19306/python/tests/test_batch_prefill_kernels.py and see how does it work. |
Hi @Narsil Any update? |
Not sure if this PR actually works correctly (I'm going to check it).
Deepseek models use head_dim=192, and this cannot be compiled because of this static assert.
This modification works by jumping like
step_size=4
+ jumping by 8 every iteration.Let me know if this is interesting in here.