-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS: Don't remove pointer after drag if released inside window #26451
MacOS: Don't remove pointer after drag if released inside window #26451
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
NSTrackingAreaOptions options = | ||
NSTrackingMouseEnteredAndExited | NSTrackingMouseMoved | NSTrackingInVisibleRect; | ||
NSTrackingAreaOptions options = NSTrackingMouseEnteredAndExited | NSTrackingMouseMoved | | ||
NSTrackingInVisibleRect | NSTrackingEnabledDuringMouseDrag; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I didn't know about this. My last deep wrestling with complex mouse tracking predated 10.5 IIRC :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. The default behavior where you get mouse exit but not enter during the same drag is just weird.
shell/platform/darwin/macos/framework/Source/FlutterViewController.mm
Outdated
Show resolved
Hide resolved
@stuartmorgan, I updated the commend and add the guard in mouseEntered: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0d40051
to
596381a
Compare
…tter#26451) * MacOS: Don't remove pointer after drag if released inside window Fixes flutter/flutter#83494 * Update has_pending_exit documentation * Do add mouse pointer if it wasn't removed.
Fixes flutter/flutter#83494
This PR adds
NSTrackingEnabledDuringMouseDrag
flag to tracking area options, which causes cocoa to signalmouseEntered:
when mouse cursor enters the window during dragging. InmouseEntered:
thehas_pending_exit
is then cleared, so flutter no longer removes the pointer if mouse is released after cursor returns to window.Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.