Move toggleable to widget layer #148272

victorsanni · 2024-05-14T00:13:43Z

Currently, toggleable exists independently in the material and cupertino libraries. Cupertino's toggleable is a minimal copy of material's, and so it makes sense to have only one toggleable in the widgets layer.

This change makes it easier for cupertino's toggleables (switch, radio, checkbox) to potentially have as many capabilities as material toggleables (for example, resolving in different widget states), thus increasing support for the cupertino library.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter/lib/src/widgets/toggleable.dart

guidezpl · 2024-05-14T06:20:07Z

packages/flutter/lib/src/widgets/toggleable.dart

+/// A mixin for [StatefulWidget]s that implement toggleable
 /// controls with toggle animations (e.g. [Switch]es, [Checkbox]es, and
 /// [Radio]s).


please mention cupertino widgets

packages/flutter/lib/src/widgets/toggleable.dart

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

Piinks

So exciting! 🎉

Re: what new tests to add? This is really great that the existing tests all pass. ✅
I think the only tests we would really need here then would be to verify that ToggleableStateMixin lives in the widgets library.

I would create a test in test/widgets/ that creates concrete classes of these abstract classes we've moved down a layer, like

import 'package:flutter/widgets.dart';

class TestPainter extends ToggleablePainter {}

That way, if the class is moved out of widgets for some reason, this file will be flagged as an analysis failure.

packages/flutter/lib/src/widgets/toggleable.dart

flutter/flutter@d2da1b2...39651e8 2024-05-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d35a1a603c80 to bf1c6da0dd31 (1 revision) (flutter/flutter#148369) 2024-05-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) (flutter/flutter#148367) 2024-05-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) (flutter/flutter#148365) 2024-05-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from dfb5871260a6 to a1d930a3a84d (2 revisions) (flutter/flutter#148360) 2024-05-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1b508a071c96 to dfb5871260a6 (1 revision) (flutter/flutter#148356) 2024-05-14 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.3.1 to 4.4.0 (flutter/flutter#148355) 2024-05-14 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `SnackBar` (flutter/flutter#147212) 2024-05-14 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in open upwards page transition (flutter/flutter#148046) 2024-05-14 47866232+chunhtai@users.noreply.github.com Fixes semantics ordering when there are multiple TextFields with prefâ�¦ (flutter/flutter#148267) 2024-05-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from ae9ff69a0840 to 1b508a071c96 (2 revisions) (flutter/flutter#148351) 2024-05-14 bruno.leroux@gmail.com Add missing InputDecorator.hintText tests (flutter/flutter#148113) 2024-05-14 katelovett@google.com Fix abi key for local golden file testing (flutter/flutter#148072) 2024-05-14 ybz975218925@gmail.com Maintain the same layout constraints for item in the ReorderableList during dragging as before dragging. (flutter/flutter#147863) 2024-05-14 82763757+NobodyForNothing@users.noreply.github.com test material text field example (flutter/flutter#147864) 2024-05-14 victorsanniay@gmail.com Move toggleable to widget layer (flutter/flutter#148272) 2024-05-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 08b44d906fab to ae9ff69a0840 (1 revision) (flutter/flutter#148341) 2024-05-14 andrewrkolos@gmail.com add another print trace to runInView (flutter/flutter#148337) 2024-05-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7bf865774d06 to 08b44d906fab (4 revisions) (flutter/flutter#148338) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

victorsanni · 2024-08-14T07:00:15Z

Related to #53059.

victorsanni added 2 commits May 13, 2024 14:20

Initial changes

863ae00

Move material toggleable to widgets layer

fe667b5

github-actions bot added framework f: material design f: cupertino labels May 14, 2024

Merge branch 'master' into toggleable-to-widget-layer

a14c9a6

victorsanni marked this pull request as ready for review May 14, 2024 00:16

guidezpl approved these changes May 14, 2024

View reviewed changes

victorsanni and others added 2 commits May 14, 2024 10:17

Update packages/flutter/lib/src/widgets/toggleable.dart

3ad9613

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

Update packages/flutter/lib/src/widgets/toggleable.dart

76a3ba1

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>

Piinks reviewed May 14, 2024

View reviewed changes

packages/flutter/lib/src/widgets/toggleable.dart Outdated Show resolved Hide resolved

victorsanni added 6 commits May 14, 2024 10:51

Apply Pierre's suggested changes

7cea3a0

Create getter for reactionAnimationDuration

e70ecc0

Merge branch 'master' into toggleable-to-widget-layer

9e82f4b

Fix imports

c92d108

Add test for toggleable

0d20125

Merge branch 'master' into toggleable-to-widget-layer

60497be

victorsanni added the autosubmit label May 14, 2024

victorsanni merged commit 7d92700 into flutter:master May 14, 2024
73 checks passed

victorsanni deleted the toggleable-to-widget-layer branch May 14, 2024 20:46

engine-flutter-autoroll mentioned this pull request May 15, 2024

Roll Flutter from d2da1b280b51 to 39651e84ea12 (18 revisions) flutter/packages#6738

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2024

7d92700 Move toggleable to widget layer (flutter/flutter#148272)

30ec702

Piinks mentioned this pull request May 17, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

7d92700 Move toggleable to widget layer (flutter/flutter#148272)

09ce1d8

Piinks mentioned this pull request Feb 18, 2025

Move the material and cupertino packages outside of Flutter #101479

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move toggleable to widget layer #148272

Move toggleable to widget layer #148272

victorsanni commented May 14, 2024 •

edited

Loading

guidezpl May 14, 2024

Piinks left a comment

victorsanni commented Aug 14, 2024 •

edited

Loading

Move toggleable to widget layer #148272

Move toggleable to widget layer #148272

Conversation

victorsanni commented May 14, 2024 • edited Loading

Pre-launch Checklist

guidezpl May 14, 2024

Choose a reason for hiding this comment

Piinks left a comment

Choose a reason for hiding this comment

victorsanni commented Aug 14, 2024 • edited Loading

victorsanni commented May 14, 2024 •

edited

Loading

victorsanni commented Aug 14, 2024 •

edited

Loading