-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera] Introduce camera_web
package
#4151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's get this landed. I've only noted a few changes wrt the 0.0.1 version being too low, and some other nitpicks.
I've checked and the integration tests are already running successfully in the CI of this change, here:
https://cirrus-ci.com/task/6318685427073024?logs=drive#L20
Good stuff!
packages/camera/camera_web/example/integration_test/helpers/helpers.dart
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a bunch of minor comments/nits but overall LGTM 🎉
Per the output:
And indeed, that file has no license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my only concern is with publishing to pub a version of the plugin that doesn't do anything. I'll try to see if there's a way of merging this and having the auto-publish code ignore it until at least we have ported over all the functionality of the Photobooth (then we can call that 0.1.0 or whatever we want).
Sounds good @ditman, thanks! |
packages/camera/camera_web/example/integration_test/camera_web_test.dart
Outdated
Show resolved
Hide resolved
You could mark it |
This needs to be rebased with the latest
|
Just added you as a collaborator so you should have permission to push now 👍 |
This comment has been minimized.
This comment has been minimized.
It is rebased and awaits @felangel consent. |
@googlebot I consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
This first version is a no-op implementation of the platform_interface, but is the initial step to bring over the implementation from the Photobooth into flutter/plugins. Won't be published (for now). Co-authored-by: Felix Angelov <[email protected]>
This first version is a no-op implementation of the platform_interface, but is the initial step to bring over the implementation from the Photobooth into flutter/plugins. Won't be published (for now). Co-authored-by: Felix Angelov <[email protected]>
Adds
camera_web
plugin, serves as a starting point for the Web platform implementation ofcamera
.camera_web
packagecamera
packageCameraPlugin
, the web implementation of the camera platform interface that throws unimplemented error for each methodPart of flutter/flutter#45297
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).