Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(node): Avoid dropUndefinedKeys in Node SDK init #15797

Merged
merged 1 commit into from
Mar 24, 2025
Merged

ref(node): Avoid dropUndefinedKeys in Node SDK init #15797

merged 1 commit into from
Mar 24, 2025
+15 −34

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 24, 2025

We can instead of ?? to get the same outcome.

@mydea
ref(node): Avoid dropUndefinedKeys in Node SDK init
f765307 
We can instead of `??` to get the same outcome.
@mydea mydea requested review from Lms24 and chargome March 24, 2025 12:37
@mydea mydea self-assigned this Mar 24, 2025
Lms24
Lms24 approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Agreed, now that we can use nullish coalescing, it's perfect for stuff like this!

@mydea mydea merged commit 244c87f into develop Mar 24, 2025
108 checks passed
@mydea mydea deleted the fn/node-sdk-dropUndefinedKeys branch March 24, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24

@chargome chargome

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mydea @Lms24