Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging from llama-llava-cli #10044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Googulator
Copy link

Use the actual logging facilities from common, instead of bespoke LOG_xxx() macros that unconditionally print to stdout/stderr.

The actual response is printed with printf(), so --log-disable won't also swallow the response.

Use the actual logging facilities from common, instead of bespoke
LOG_xxx() macros that unconditionally print to stdout/stderr.

The actual response is printed with printf(), so --log-disable won't
also swallow the response.
@ggerganov
Copy link
Owner

The llava/clip.cpp and llava/llava.cpp should not depend on libcommon.

@Googulator
Copy link
Author

Isn't the whole point of having a library named "common" is that any component (that's not itself a dependency of libcommon) can use it?

@ggerganov
Copy link
Owner

The libcommon is intended to be used only by the examples and not by libllama. The llava and clip code is potentially going to be merged in libllama in the future, so that's why we should keep it decoupled from libcommon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants