Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/create-github-app-token from 1.10.3 to 1.11.0 in the actions group #2485

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps the actions group with 1 update: actions/create-github-app-token.

Updates actions/create-github-app-token from 1.10.3 to 1.11.0

Release notes

Sourced from actions/create-github-app-token's releases.

v1.11.0

What's Changed

Features

New Contributors

Full Changelog: actions/create-github-app-token@v1.10.4...v1.11.0

v1.10.4

What's Changed

Bug Fixes

New Contributors

Full Changelog: actions/create-github-app-token@v1.10.3...v1.10.4

Commits
  • 5d869da build(release): 1.11.0 [skip ci]
  • 796b88d feat: allow repositories input to be comma or newline-separated (#169)
  • 3378cda build(release): 1.10.4 [skip ci]
  • e177c20 fix(deps): bump the production-dependencies group across 1 directory with 3 u...
  • 961c228 build(deps-dev): bump the development-dependencies group across 1 directory w...
  • 15db037 test: fix test file extensions and inputs for repositories (#161)
  • 9ccc6db ci(test): add workflow_dispatch trigger
  • 000e2a0 docs(readme): document how a Base64 private key could be decoded (#155)
  • d0ac2ad docs(README): fix the git committer string and Configure git CLI examples...
  • 040c259 build(deps-dev): bump the development-dependencies group with 4 updates (#150)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot requested a review from a team as a code owner September 16, 2024 18:02
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Sep 16, 2024
@dependabot dependabot bot requested a review from a team September 16, 2024 18:02
@angelapwen angelapwen closed this Sep 16, 2024
@angelapwen angelapwen reopened this Sep 16, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 16, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@angelapwen
Copy link
Contributor

Hm...

Uploading results
  Processing sarif files: ["eslint.sarif"]
  Validating eslint.sarif
  Combining SARIF files using the CodeQL CLI
  Adding fingerprints to SARIF file. See https://docs.github.com/en/enterprise-cloud@latest/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#providing-data-to-track-code-scanning-alerts-across-runs for more information.
  Uploading results
  Warning: Resource not accessible by integration
  Error: Resource not accessible by integration
  Warning: Workflows triggered by Dependabot on the "push" event run with read-only access. Uploading Code Scanning results requires write access. To use Code Scanning with Dependabot, please ensure you are using the "pull_request" event for this workflow and avoid triggering on the "push" event for Dependabot branches. See https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning#scanning-on-push for more information on how to configure these events.

@aeisenberg do you think the current failure is related to #2474?

@henrymercer
Copy link
Contributor

henrymercer commented Sep 23, 2024

Perhaps we could add a condition like !startsWith(github.head_ref, 'dependabot/') to the upload SARIF step?

Bumps the actions group with 1 update: [actions/create-github-app-token](https://github.com/actions/create-github-app-token).


Updates `actions/create-github-app-token` from 1.10.3 to 1.11.0
- [Release notes](https://github.com/actions/create-github-app-token/releases)
- [Commits](actions/create-github-app-token@31c86eb...5d869da)

---
updated-dependencies:
- dependency-name: actions/create-github-app-token
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions-a88a8c5a24 branch from fb777f4 to b436a5f Compare September 23, 2024 17:57
@aeisenberg
Copy link
Contributor

Sorry...I missed this ping last week. I think you're right that we will need to add something to prevent uploading sarif for dependabot runs.

We'll need to add this to vscode-codeql as well.

@rvermeulen
Copy link
Contributor

rvermeulen commented Sep 23, 2024

If it is only readonly on a push by Dependabot, shouldn't we limit the push target to main?

The synchronize will respond to the pushes by Dependabot and run as a regular workflow if I read the error correctly.

@aeisenberg
Copy link
Contributor

aeisenberg commented Sep 23, 2024

I didn't even realize we were running on all pushes. Looks like branches were removed here: 38a0291. The rationale behind the change makes sense, but I'm also open to reevaluating it.

We'd also need to include v2, v3, and v* (as we add new versions).

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrew for #2499. This is now green, so approving.

@henrymercer henrymercer merged commit 426821d into main Sep 23, 2024
262 checks passed
@henrymercer henrymercer deleted the dependabot/github_actions/actions-a88a8c5a24 branch September 23, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants