BigQuery, BigQuery Storage: Fix list_rows() max results with BQ storage client #9178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If max results is set, the streaming API should not be used, and a user warning is issued.
plamut
added
api: bigquery
googlebot
added
the
cla: yes
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 11, 2019
If max results is set, the streaming API should not be used, and a user warning is issued.
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
If max results is set, the streaming API should not be used, and a user warning is issued.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9174.
This PR fixes the issue with
max_resultsif BQ storage API is used by falling back to thetabledata.listAPI endpoint, and issuing a user warning.How to test
Run the code sample from the issue description, and verify that indeed only 100 rows is returned regardless of which client (BQ or BQ storage) is used.