Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add use_topic_schema for Cloud Storage Subscriptions #1948

Merged
merged 6 commits into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
test/fixtures
build/
docs/
owl-bot-staging/
protos/
samples/generated/
system-test/**/fixtures
12 changes: 12 additions & 0 deletions .github/.header-checker-lint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
allowedCopyrightHolders:
- 'Google LLC'
allowedLicenses:
- 'Apache-2.0'
- 'MIT'
- 'BSD-3'
sourceFileExtensions:
- 'ts'
- 'js'
- 'java'
ignoreFiles:
- 'owl-bot-staging/**'
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
/docs/
/out/
/build/
samples/build/
system-test/secrets.js
system-test/*key.json
*.lock
Expand Down
4 changes: 3 additions & 1 deletion owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,7 @@
node.owlbot_main(templates_excludes=[
'src/index.ts',
'.github/PULL_REQUEST_TEMPLATE.md',
'.github/release-please.yml'
'.github/release-please.yml',
'.github/header-checker-lint.yaml',
'.eslintignore'
])
8 changes: 8 additions & 0 deletions protos/google/pubsub/v1/pubsub.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1168,6 +1168,10 @@ message CloudStorageConfig {
// data (for example, an ordering_key, if present) are added as entries in
// the attributes map.
bool write_metadata = 1 [(google.api.field_behavior) = OPTIONAL];

// Optional. When true, the output Cloud Storage file will be serialized
// using the topic schema, if it exists.
bool use_topic_schema = 2 [(google.api.field_behavior) = OPTIONAL];
}

// Possible states for a Cloud Storage subscription.
Expand All @@ -1188,6 +1192,10 @@ message CloudStorageConfig {
// Cannot write to the destination because enforce_in_transit is set to true
// and the destination locations are not in the allowed regions.
IN_TRANSIT_LOCATION_RESTRICTION = 4;

// Cannot write to the Cloud Storage bucket due to an incompatibility
// between the topic schema and subscription settings.
SCHEMA_MISMATCH = 5;
}

// Required. User-provided name for the Cloud Storage bucket.
Expand Down
9 changes: 8 additions & 1 deletion protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 32 additions & 1 deletion protos/protos.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions samples/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
build/
Loading