fix: zIndex for Clustering #1484
Open
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erRendered and onBeforeClusterItemRendered
kikoso
changed the title
dkhawk
approved these changes
Mar 18, 2025
dkhawk
reviewed
Mar 25, 2025
| @@ -906,6 +910,13 @@ protected void onClusterItemUpdated(@NonNull T item, @NonNull Marker marker) { | |||
| protected void onBeforeClusterRendered(@NonNull Cluster<T> cluster, @NonNull MarkerOptions markerOptions) { | |||
| // TODO: consider adding anchor(.5, .5) (Individual markers will overlap more often) | |||
| markerOptions.icon(getDescriptorForCluster(cluster)); | |||
| Iterator<T> iterator = cluster.getItems().iterator(); | |||
There was a problem hiding this comment.
This code next more explanation. What is the goal of this code and how does it work?
It also strike me as very odd. I am not used to seeing an iterator w/o a loop. This has a strange code smell to it. If the intent is to only use the second element of the cluster, this seems like a very strange way to go about it.
There was a problem hiding this comment.
Cluster.getItems() returns Collection.
Since there are no methods like get in the Collection interface, I use iterator to get the first element.
I see another way to do this:
ArrayList<T> items = new ArrayList<>(cluster.getItems());
Do you think this option would be clearer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add zIndex to markerOptions in onBeforeClusterRendered and onBeforeClusterItemRendered
Fixes #1424