Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@graphiql/toolkit] do not include require statements in ESM build, include import in esm and require in cjs builds #3747

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Aug 23, 2024

fixes #3668

cjs

image

esm

image

Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: ce0f220

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphiql/toolkit Minor
@graphiql/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.23%. Comparing base (2ad4e75) to head (ce0f220).
Report is 1 commits behind head on main.

Files Patch % Lines
...aphiql-toolkit/src/create-fetcher/createFetcher.ts 50.00% 1 Missing ⚠️
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3747      +/-   ##
==========================================
- Coverage   67.24%   67.23%   -0.02%     
==========================================
  Files         121      121              
  Lines        7007     7007              
  Branches     2259     2262       +3     
==========================================
- Hits         4712     4711       -1     
- Misses       2278     2279       +1     
  Partials       17       17              
Files Coverage Δ
...aphiql-toolkit/src/create-fetcher/createFetcher.ts 44.00% <50.00%> (ø)
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 57.62% <80.00%> (-1.70%) ⬇️

Copy link
Contributor

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@dimaMachina dimaMachina merged commit 21c4409 into main Aug 23, 2024
14 checks passed
@dimaMachina dimaMachina deleted the do-not-include-require-in-esm branch August 23, 2024 20:41
@acao acao mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[graphiql] CommonJS syntax in ESM build
1 participant