Fix for multiple build targets at cabal-add #4393
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for multiple build targets at cabal-add
In my current merged solution, cabal-add
CodeAction
is provided only for the main target.This was only a temporary solution due to limitations of the
getBuildTargets
function.For more information, consult this thread.
Now it was fixed, and you can choose to what target add the dependency.
Video with an example:
cabal-add-continuation-cut.mp4
Also, I changed the title for the
CodeAction
, to a hopefully better one.Implementation details
I changed the functions
getBuildTargets
andbuildTargetComponentName
tothe
getBuildTargetComponentNames
that handlesGenericPackageDescription
and givesComponentName
s of all targets.What isn't implemented
CodeAction
. Now this leads to a race condition.