Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove padding from JWK test data. #628

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

dajiaji
Copy link
Contributor

@dajiaji dajiaji commented Mar 13, 2021

No description provided.

Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason this is required?

@dajiaji
Copy link
Contributor Author

dajiaji commented Mar 14, 2021

Thanks for checking this PR.

base64url encoding can skip padding("="). Many jwk implementations that I know of omit the padding, and I thought that test data would be better suited to the common implementation.

However, skipping padding is not mandatory so I'll leave it up to you to decide if you want to accept this PR.

Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add this to the CHANGELOG?

@jpadilla jpadilla merged commit a87a7a1 into jpadilla:master Mar 18, 2021
@dajiaji dajiaji deleted the remove-padding-from-test-vector branch March 20, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants