Properly set logger before creating a typed client #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
requested review from
TheBigLee and
zugao
and removed request for
a team
During pre-backup operations it was possible that the typed client was initialized without setting the logger first. Which lead to a big, but harmless, stacktrace in the backup pods. This commit makes sure that the logger will be set every time the client gets created. Signed-off-by: Simon Beck <[email protected]>
Kidswiss
force-pushed
the
fix/logger_not_set
branch
from
35b6b55
to
9614a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During pre-backup operations it was possible that the typed client was initialized without setting the logger first. Which lead to a big, but harmless, stacktrace in the backup pods.
This commit makes sure that the logger will be set every time the client gets created.
Resolves: #981
Checklist
For Code changes
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
area:operatorcharts/directory.