feat(style): Add aerial style config and allow swap-able TileMatrix in the source urls. #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Wentao-Kuang
commented
Jun 12, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
blacha
reviewed
Jun 13, 2024
Wentao-Kuang
commented
Jun 23, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Wentao-Kuang
commented
Jun 23, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-merge-queue bot
pushed a commit
to linz/basemaps
that referenced
this pull request
Jun 26, 2024
### Motivation We want a terrain request parameter that shareable for map with 3d terrain enabled. This will need new aerial style config to added after merge. linz/basemaps-config#916 ### Modifications - Add terrain setting in `getStyle` api when `?terrain=LINZ-Terrain` - Update landing page to lisen the terrain event to set terrain parameter.  ### Verification - Unit tests added for tileset to style and style to style in getStyle Api - Landing page tested with terrain button to update the request parameter.
github-merge-queue bot
pushed a commit
to linz/basemaps
that referenced
this pull request
Jun 26, 2024
…#3299) ### Motivation We need to ensure a terrain source in all style json configs before the production release. Then we could do another config release for add terrain source into style config. linz/basemaps-config#916 ### Modifications Check and add terrain source for get style config api. ### Verification 
This comment was marked as outdated.
This comment was marked as outdated.
Wentao-Kuang
commented
Jul 10, 2024
Vector Style UpdateVector Style updated for st_aerialVector Style updated for st_aerialhybridVector Style updated for st_basicVector Style updated for st_positronVector Style updated for st_topographicVector Style updated for st_topolite |
Vector Style UpdateVector Style updated for st_aerialVector Style updated for st_aerialhybridVector Style updated for st_basicVector Style updated for st_topographicVector Style updated for st_positronVector Style updated for st_topolite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the latest basemaps release V7.5 and V7.6.
We can support aerial style json, and switchable tilematrix in the tileset url.
Modification
@2022to@2024Checklist
If not applicable, provide explanation of why.