-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some examples #260
Add some examples #260
Conversation
@Tinyu-Zhao Usually, after submitting a pull request, you should not make any other changes until it is merged. |
Sorry, I don’t know that this will cause a lot of emails to be sent, I will try to work in other branches
Tinyu Chiu
2021年9月3日 +0800 08:39 lovyan03 ***@***.***>,写道:
… @Tinyu-Zhao
Why do you keep committing pull requests before they are merged?
I'm very tired of getting a lot of useless notifications because of you.
Usually, after submitting a pull request, you should not make any other changes until it is merged.
You should work in separate branches.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@Tinyu-Zhao |
Thank you for your reminder, otherwise I might keep this wrong bad habit
Tinyu Chiu
2021年9月3日 +0800 08:48 lovyan03 ***@***.***>,写道:
… @Tinyu-Zhao
When you submit a pull request, don't make any changes to the branch until it has been merged, rejected, or concluded in some other way.
A pull request should be submitted when the change work is complete and ready to be safely merged.
You should not submit a pull request from a branch you are working on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
No description provided.