Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some examples #260

Merged
merged 24 commits into from
Sep 3, 2021
Merged

Add some examples #260

merged 24 commits into from
Sep 3, 2021

Conversation

Tinyu-Zhao
Copy link
Collaborator

No description provided.

@ghost
Copy link

ghost commented Sep 1, 2021

#261

@lovyan03
Copy link
Contributor

lovyan03 commented Sep 3, 2021

@Tinyu-Zhao
Why do you keep committing pull requests before they are merged?
I'm very tired of getting a lot of useless notifications because of you.

image

Usually, after submitting a pull request, you should not make any other changes until it is merged.
You should work in separate branches.

@Tinyu-Zhao
Copy link
Collaborator Author

Tinyu-Zhao commented Sep 3, 2021 via email

@lovyan03
Copy link
Contributor

lovyan03 commented Sep 3, 2021

@Tinyu-Zhao
When you submit a pull request, don't make any changes to the branch until it has been merged, rejected, or concluded in some other way.
A pull request should be submitted when the change work is complete and ready to be safely merged.
You should not submit a pull request from a branch you are working on.

@Tinyu-Zhao
Copy link
Collaborator Author

Tinyu-Zhao commented Sep 3, 2021 via email

@Tinyu-Zhao Tinyu-Zhao changed the title Update Add some examples Sep 3, 2021
@Tinyu-Zhao Tinyu-Zhao merged commit b402122 into m5stack:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants