[New Component] Tab component with MDCTabBar #1164

brianjmoore · 2017-01-23T18:17:37Z

This adds a new Tabs components with an MDCTabBar class that implements a material-style tab bar.

…components#711) * Add initial headers for MDC*Bar * Initial chunk of work * It works…ish * Update demo images and update style with appearance * Update Podfile.lock * Merge * Merge * Revert bottom bar for now * Update description * Formatting and cleanup * Manual revert of mistaken changes * Manual revert of mistaken changes * Manual revert of mistaken changes * Update with consistent terminology * Update constant names * Update localizable strings * More naming updates * Rename TabBar to Tabs, move ItemBar into Tabs/private * Rename string keys * Rename string files from ItemBar to Tabs * Rename string keys header * Update podspec and move bundle * Reset Podfile.lock in preparation for re-updating * Clean update to Podfile.lock, adding MaterialTabs * Update import paths * Move CatalogByConvention method to end of file * Add copyright notice on all h/m files * Add safe fallbacks for switches * Use conventional common init method name * Podfile.lock checksum update

Intro content

Master updated to match upstream

…components#711) * Add initial headers for MDC*Bar * Initial chunk of work * It works…ish * Update demo images and update style with appearance * Update Podfile.lock * Merge * Merge * Revert bottom bar for now * Update description * Formatting and cleanup * Manual revert of mistaken changes * Manual revert of mistaken changes * Manual revert of mistaken changes * Update with consistent terminology * Update constant names * Update localizable strings * More naming updates * Rename TabBar to Tabs, move ItemBar into Tabs/private * Rename string keys * Rename string files from ItemBar to Tabs * Rename string keys header * Update podspec and move bundle * Reset Podfile.lock in preparation for re-updating * Clean update to Podfile.lock, adding MaterialTabs * Update import paths * Move CatalogByConvention method to end of file * Add copyright notice on all h/m files * Add safe fallbacks for switches * Use conventional common init method name * Podfile.lock checksum update

…l-components-ios into feature-tabs

[Tabs] Fix podspec for resource bundle key

Split Tabs examples into 2 and updated organization inside them

[Tabs] Overview content

…ents-ios into feature-tabs

…re-tabs # Conflicts: # .travis.yml # catalog/Podfile.lock # components/NavigationBar/src/MDCNavigationBar.m # demos/Shrine/Shrine/ShrineHeaderContentView.swift # scripts/build_all # scripts/test_all

googlebot · 2017-01-23T18:18:01Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

willlarche · 2017-01-23T18:58:08Z

I consent to having my changes included in this PR.

codecov-io · 2017-01-23T21:39:46Z

Current coverage is 26.36% (diff: 0.41%)

No coverage report found for develop at 8490f6e.

Powered by Codecov. Last update 8490f6e...dfd38e3

ajsecord · 2017-01-24T22:23:05Z

components/Tabs/README.md

+<!--    <a href="https://material.google.com/components/bottom-navigation.html">-->
+<!--      Bottom navigation-->
+<!--    </a>-->
+<!--  </li>-->


samnm

LGTM aside from some minor comments

samnm · 2017-01-24T20:46:58Z

catalog/Podfile.lock

@@ -162,11 +168,11 @@ DEPENDENCIES:

 EXTERNAL SOURCES:
  MaterialComponents:
-    :path: "../"
+    :path: ../


If you update the rubygem 'psych', newly generated Podfiles will include the quotation marks. Try sudo gem update psych.

Thanks. Done

samnm · 2017-01-24T21:21:47Z

components/AppBar/examples/resources/AppBarInterfaceBuilderExampleController.storyboard

@@ -1,8 +1,12 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="10117" systemVersion="15G1108" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" initialViewController="BYZ-38-t0r">
+<?xml version="1.0" encoding="UTF-8"?>


Did you mean to edit this file?

Hmmm... Probably not.

samnm · 2017-01-24T22:32:41Z

components/Tabs/src/private/MDCItemBar.m

+  }
+}
+
+#pragma mark - GOOAccessibility


Should this just say Accessibility?

Good catch!

willlarche · 2017-01-25T16:52:14Z

Verified build is good with another Travis and local testing. This Travis is not trusted.

brianjmoore and others added 30 commits October 4, 2016 14:20

[Tabs] Initial README template and changes

cd4fa5e

[Tabs] Updating intro content.

1535362

[Tabs] Commenting out mention of bottom navigation bars in readme.

b6d52d1

Merge pull request #1 from brianjmoore/feature-tabs-will

4161928

Intro content

Merge pull request #2 from brianjmoore/master-updated

4db7d0b

Master updated to match upstream

[Tabs] Initial README template and changes

b50d6c0

[Tabs] Updating intro content.

60d74bc

[Tabs] Commenting out mention of bottom navigation bars in readme.

9a87a8d

Merge branch 'feature-tabs' of https://github.com/brianjmoore/materia…

19f12eb

…l-components-ios into feature-tabs

[Tabs] Correcting resources key in pod spec.

33c38b3

[Tabs] Correcting implementation of resources key in pod spec.

7f91d3b

[Tabs] Removing duplicate entry in pod spec (cherry pick artifact.)

5feb5fb

Merge pull request #3 from brianjmoore/fix-podspec-bundle

0cfab98

[Tabs] Fix podspec for resource bundle key

[Tabs] Overview written

d1f59df

[Tabs] Mentioning badges in overview.

31aa4aa

[Tabs] Removing TODO in ready.

36e8454

[Tabs] Duplicating tabs example in prep for splitting it into two.

2a75ea2

[Tabs] Examples crudely split apart.

7879580

[Pods] Update of lock, catalog and tests for new version.

89af1b4

[Tabs] Refactored examples to be in style of supplemented examples.

a51908c

[Tabs] Formatting.

3bb795d

[Tabs] Formatting.

ba6ff44

[Tabs] Formatting.

2f1bcf2

Merge pull request #5 from brianjmoore/feature-tabs-examples

64fdf43

Split Tabs examples into 2 and updated organization inside them

Merge pull request #4 from brianjmoore/feature-tabs-overview

bdeb5f2

[Tabs] Overview content

Add usage examples

e4f9af2

Add usage examples

89e55c5

Merge branch 'feature-tabs' of github.com:brianjmoore/material-compon…

946a5c2

…ents-ios into feature-tabs

willlarche and others added 14 commits January 17, 2017 13:41

[Tabs] Adding IBOutlet for delegate (optional.)

7e607ee

[Tabs] Fix 32-bit build

3e8e4f0

[Tabs] Interface Builder example.

eaf73a9

[Tabs] Beginning Swift example.

eabb0b0

[Tabs] More swift example content.

5baee33

[Tabs] Swift example complete

557dd38

[Tabs] Swift example PR note implementations.

3823b8f

[Tabs] Swift formatting

ba97036

[Tabs] Formatting in example

c1e0015

[Tabs] Formatting swift example.

5602922

[Tabs] Swift example clarity.

8af3636

[Tabs] Example wrapping revert.

a6cf6ef

[Tabs] Example wrapping revert.

a60d25b

Merge remote-tracking branch 'material-components/develop' into featu…

dfd38e3

…re-tabs # Conflicts: # .travis.yml # catalog/Podfile.lock # components/NavigationBar/src/MDCNavigationBar.m # demos/Shrine/Shrine/ShrineHeaderContentView.swift # scripts/build_all # scripts/test_all

googlebot added the cla: no label Jan 23, 2017

willlarche added the [Tabs] label Jan 23, 2017

samnm assigned samnm and unassigned samnm Jan 24, 2017

samnm self-requested a review January 24, 2017 20:14

ajsecord approved these changes Jan 24, 2017

View reviewed changes

samnm approved these changes Jan 24, 2017

View reviewed changes

brianjmoore added 2 commits January 25, 2017 09:51

Merge branch 'develop' into feature-tabs

571139b

Fixes from review

0b17e47

willlarche changed the title ~~Tab component with MDCTabBar~~ [New Component] Tab component with MDCTabBar Jan 25, 2017

willlarche merged commit fd074fc into material-components:develop Jan 25, 2017

brianjmoore deleted the feature-tabs branch January 25, 2017 16:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New Component] Tab component with MDCTabBar #1164

[New Component] Tab component with MDCTabBar #1164

brianjmoore commented Jan 23, 2017

googlebot commented Jan 23, 2017

willlarche commented Jan 23, 2017 via email •

edited

Loading

codecov-io commented Jan 23, 2017

ajsecord Jan 24, 2017

brianjmoore Jan 25, 2017

samnm left a comment

samnm Jan 24, 2017

brianjmoore Jan 25, 2017

samnm Jan 24, 2017

willlarche Jan 24, 2017

brianjmoore Jan 25, 2017

samnm Jan 24, 2017

brianjmoore Jan 25, 2017

willlarche commented Jan 25, 2017

[New Component] Tab component with MDCTabBar #1164

[New Component] Tab component with MDCTabBar #1164

Conversation

brianjmoore commented Jan 23, 2017

googlebot commented Jan 23, 2017

willlarche commented Jan 23, 2017 via email • edited Loading

codecov-io commented Jan 23, 2017

Current coverage is 26.36% (diff: 0.41%)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samnm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

willlarche commented Jan 25, 2017

willlarche commented Jan 23, 2017 via email •

edited

Loading