Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Multiple Xcodes including Xcode 9 and iPhone X #2084

Conversation

willlarche
Copy link
Collaborator

No description provided.

@chuga
Copy link

chuga commented Oct 3, 2017

giphy

@codecov-io
Copy link

codecov-io commented Oct 3, 2017

Codecov Report

Merging #2084 into develop will increase coverage by 3.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2084      +/-   ##
===========================================
+ Coverage    43.29%   46.75%   +3.46%     
===========================================
  Files          206      208       +2     
  Lines        17847    21557    +3710     
  Branches      1815     1831      +16     
===========================================
+ Hits          7726    10080    +2354     
- Misses        9515    11464    +1949     
+ Partials       606       13     -593
Impacted Files Coverage Δ
components/private/Math/src/MDCMath.h 78.31% <0%> (-21.69%) ⬇️
components/private/RTL/src/UIView+MaterialRTL.m 54.79% <0%> (-16.95%) ⬇️
components/private/RTL/src/UIImage+MaterialRTL.m 32.6% <0%> (-11.66%) ⬇️
...ents/private/ThumbTrack/src/MDCNumericValueLabel.m 35% <0%> (-10.29%) ⬇️
...ing/src/CAMediaTimingFunction+MDCAnimationTiming.m 36.36% <0%> (-6.5%) ⬇️
...s/private/KeyboardWatcher/src/MDCKeyboardWatcher.m 20.86% <0%> (-4.14%) ⬇️
...ts/CollectionCells/src/MDCCollectionViewTextCell.m 38.92% <0%> (-1.68%) ⬇️
components/private/Icons/src/MDCIcons.m 72.22% <0%> (-1.12%) ⬇️
...Collections/src/private/MDCCollectionInfoBarView.m 18.36% <0%> (-0.9%) ⬇️
components/private/RTL/src/MDCRTL.m 52.63% <0%> (-0.71%) ⬇️
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e4ae7...dae09ed. Read the comment docs.

@willlarche willlarche merged commit 20cf52d into material-components:develop Oct 4, 2017
@willlarche willlarche deleted the feature-travis-multipleXcodes branch October 4, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes type:Test A test must be written.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants