Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomNavigation] Add NSCoding tests #2740

Merged
merged 1 commit into from
Dec 18, 2017
Merged

[BottomNavigation] Add NSCoding tests #2740

merged 1 commit into from
Dec 18, 2017

Conversation

romoore
Copy link
Contributor

@romoore romoore commented Dec 16, 2017

BottomNavigation needs to fully support NSCoding so that clients can use state
restoration if desired.

Closes #2737

BottomNavigation needs to fully support NSCoding so that clients can use state
restoration if desired.

Closes #2737
@codecov-io
Copy link

Codecov Report

Merging #2740 into develop will increase coverage by 1.51%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2740      +/-   ##
===========================================
+ Coverage    45.38%   46.89%   +1.51%     
===========================================
  Files          165      165              
  Lines        24493    24630     +137     
  Branches      1013     1062      +49     
===========================================
+ Hits         11116    11551     +435     
+ Misses       13316    13016     -300     
- Partials        61       63       +2
Impacted Files Coverage Δ
...igation/src/private/MDCBottomNavigationItemBadge.m 74.66% <100%> (+74.66%) ⬆️
...ents/BottomNavigation/src/MDCBottomNavigationBar.m 58.99% <100%> (+47.87%) ⬆️
...vigation/src/private/MDCBottomNavigationItemView.m 84.73% <100%> (+84.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35ca83b...80eb9c2. Read the comment docs.

@romoore romoore merged commit 86002fe into material-components:develop Dec 18, 2017
@romoore romoore deleted the issue-2737 branch December 18, 2017 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants