Update MaterialComponents podspec to separate extensions from component. Breaking change, please see description when sending out a new release #2748
Conversation
…ponents-ios into develop
…ponents-ios into develop
…ponents-ios into develop
…ponents-ios into develop
…ponents-ios into develop
…ponents-ios into develop
…ponents-ios into develop
…ponents-ios into develop
MaterialComponents.podspec
Outdated
| @@ -102,29 +104,30 @@ Pod::Spec.new do |mdc| | |||
|
|
|||
| component.dependency "MDFInternationalization" | |||
| component.dependency "MaterialComponents/Buttons" | |||
| component.dependency "MaterialComponents/NavigationBar" | |||
| component.dependency "MaterialComponents/NavigationBar+Extensions" | |||
There was a problem hiding this comment.
Confirming that we are intentionally bringing in the extensions here.
If so, can we bring in a more specific subset of extensions?
There was a problem hiding this comment.
Unfortunately so: https://github.com/material-components/material-components-ios/blob/develop/components/BottomAppBar/src/MDCBottomAppBarView.m#L101
I will update it to point only to the themer in case more extensions are added in the future.
MaterialComponents.podspec
Outdated
| spec.source_files = "components/#{component.base_name}/src/#{spec.base_name}/*.{h,m}" | ||
| spec.dependency "MaterialComponents/ButtonBar/Component" | ||
| spec.dependency "MaterialComponents/NavigationBar/Component" | ||
| spec.public_header_files = "components/ButtonBar/src/#{spec.base_name}/*.h" |
There was a problem hiding this comment.
May be reasonable to do a find and replace of 'spec' with 'extension' now.
Codecov Report
@@ Coverage Diff @@
## develop #2748 +/- ##
===========================================
- Coverage 46.89% 46.74% -0.15%
===========================================
Files 165 165
Lines 24651 24797 +146
Branches 1060 1063 +3
===========================================
+ Hits 11559 11591 +32
- Misses 13029 13141 +112
- Partials 63 65 +2
Continue to review full report at Codecov.
|
yarneo
changed the title
This solves #2696
To install the component without any extensions:
pod MaterialComponents/<Component>To install the component with all its extensions:
pod MaterialComponents/<Component>+ExtensionsTo install the component with only one if its extensions:
pod MaterialComponents/<Component>+Extensions/<Extension>@randallli is good with this approach, we discussed offline.
I will add a isBreaking label and won't merge for now, as we should discuss the implications of current users having a
pod MaterialComponents/<Component>and expecting the extensions to come with it.The podspec passes
pod spec lintThis is a breaking change, so when pushing out a new version please make sure to add a note of this change in the CHANGELOG with possibly adding the above examples of usage