Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples/Tests] Convert @imports to imports #2761

Merged
merged 1 commit into from
Dec 22, 2017
Merged

[Examples/Tests] Convert @imports to imports #2761

merged 1 commit into from
Dec 22, 2017

Conversation

romoore
Copy link
Contributor

@romoore romoore commented Dec 22, 2017

In order to make the internal build systems happier, @import statements should not be used.

In order to make the internal build systems happier, @import statements should not be used.
@romoore romoore added is:Internal type:Internal cleanup Refactoring work is required. labels Dec 22, 2017
@ianegordon ianegordon added the PR is blocked Please explain why. label Dec 22, 2017
@ianegordon
Copy link
Contributor

Let's chat on this tomorrow.

@codecov-io
Copy link

Codecov Report

Merging #2761 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2761   +/-   ##
========================================
  Coverage    46.89%   46.89%           
========================================
  Files          165      165           
  Lines        24651    24651           
  Branches      1060     1060           
========================================
  Hits         11561    11561           
  Misses       13027    13027           
  Partials        63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0681399...eed60ef. Read the comment docs.

@romoore romoore removed the PR is blocked Please explain why. label Dec 22, 2017
@romoore
Copy link
Contributor Author

romoore commented Dec 22, 2017

This is necessary for both internal builds, but also for bazel builds on kokoro. In order for us to include building our examples (a very good thing) on Kokoro, we'll have to make this change until bazel supports modules imports.

@romoore romoore requested review from ianegordon and removed request for ianegordon December 22, 2017 16:03
Copy link
Contributor

@ianegordon ianegordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged. Let's make sure we open an issue with the Bazel team if there isn't one already.

@ianegordon ianegordon self-requested a review December 22, 2017 16:52
@romoore romoore merged commit e031865 into material-components:develop Dec 22, 2017
@romoore romoore deleted the change-imports branch December 22, 2017 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes type:Internal cleanup Refactoring work is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants