-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Examples/Tests] Convert @imports to imports #2761
Conversation
In order to make the internal build systems happier, @import statements should not be used.
Let's chat on this tomorrow. |
Codecov Report
@@ Coverage Diff @@
## develop #2761 +/- ##
========================================
Coverage 46.89% 46.89%
========================================
Files 165 165
Lines 24651 24651
Branches 1060 1060
========================================
Hits 11561 11561
Misses 13027 13027
Partials 63 63 Continue to review full report at Codecov.
|
This is necessary for both internal builds, but also for bazel builds on kokoro. In order for us to include building our examples (a very good thing) on Kokoro, we'll have to make this change until bazel supports modules imports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledged. Let's make sure we open an issue with the Bazel team if there isn't one already.
In order to make the internal build systems happier, @import statements should not be used.