Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chips] Fix accessoryPadding encoding key #2773

Merged
merged 2 commits into from
Dec 30, 2017
Merged

[Chips] Fix accessoryPadding encoding key #2773

merged 2 commits into from
Dec 30, 2017

Conversation

romoore
Copy link
Contributor

@romoore romoore commented Dec 29, 2017

Encoding issues a warning because the titlePadding value is overwritten with
the accessoryPadding value during archival.

Encoding issues a warning because the titlePadding value is overwritten with
the accessoryPadding value during archival.
@codecov-io
Copy link

Codecov Report

Merging #2773 into develop will increase coverage by 1.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #2773     +/-   ##
=========================================
+ Coverage    46.89%   48.2%   +1.3%     
=========================================
  Files          165     165             
  Lines        24651   24651             
  Branches      1060    1077     +17     
=========================================
+ Hits         11561   11882    +321     
+ Misses       13027   12701    -326     
- Partials        63      68      +5
Impacted Files Coverage Δ
components/Chips/src/MDCChipView.m 49.6% <100%> (+27.55%) ⬆️
components/private/Math/src/MDCMath.h 59.13% <0%> (+17.39%) ⬆️
...s/private/ShapeLibrary/src/MDCPillShapeGenerator.m 52.17% <0%> (+17.39%) ⬆️
...mponents/private/Shapes/src/MDCShapedShadowLayer.m 63.85% <0%> (+24.09%) ⬆️
components/private/Shapes/src/MDCEdgeTreatment.m 50% <0%> (+25%) ⬆️
...ivate/ShapeLibrary/src/MDCRoundedCornerTreatment.m 66.66% <0%> (+28.57%) ⬆️
components/private/Shapes/src/MDCPathGenerator.m 38.82% <0%> (+38.82%) ⬆️
...ts/private/Shapes/src/MDCRectangleShapeGenerator.m 67.28% <0%> (+60.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e031865...b24142b. Read the comment docs.

@romoore romoore merged commit 873e687 into material-components:develop Dec 30, 2017
@romoore romoore deleted the fix-chips-encoding branch November 13, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants