Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify "*WordPart*" family of commands to respect kebab-case (resolves #158667) #158672

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

nikita-r
Copy link
Contributor

@nikita-r nikita-r commented Aug 20, 2022

Fixes #158667

Fixes this family of commands to behave as expected for kebab-case-variables when the "editor.wordSeparators" setting does not include "-"; tests included.
image

@ghost
Copy link

ghost commented Aug 20, 2022

CLA assistant check
All CLA requirements met.

@nikita-r nikita-r changed the title Modify "*WordPart*" family of commands to respect kebab-case (#158667) Modify "*WordPart*" family of commands to respect kebab-case (resolves #158667) Aug 20, 2022
@jrieken jrieken assigned alexdima and unassigned jrieken Sep 8, 2022
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #158667 (comment)

alexdima
alexdima previously approved these changes Oct 24, 2022
@alexdima alexdima added this to the October 2022 milestone Oct 24, 2022
@alexdima alexdima merged commit 6399d03 into microsoft:main Oct 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cursorWordPartLeft doesn't stop at - when it is excluded from editor.wordSeparators
6 participants