Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disable privileged ports for OSX #163890

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Oct 17, 2022

Fixes #160266

Requires to update setting"remote.localPortHost": "allInterfaces" in macos to properly work

mcbridenMoey
mcbridenMoey previously approved these changes Oct 17, 2022
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a few comments.

src/vs/platform/tunnel/node/tunnelService.ts Outdated Show resolved Hide resolved
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to do some testing then I'll approve. Thanks for the changes!

src/vs/platform/tunnel/node/tunnelService.ts Outdated Show resolved Hide resolved
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@alexr00 alexr00 merged commit 314bda9 into microsoft:main Oct 21, 2022
@jeanp413 jeanp413 deleted the mac-priviledge-ports branch October 22, 2022 02:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Privileged ports for OSX
5 participants