Update to support strictBuiltinIteratorReturn #222009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've filed this as a Draft PR in the event there are any other changes to microsoft/TypeScript#58243 that must be addressed. Once that PR has merged, I will mark this PR as "Ready for review". |
|
Looks like the TS side of the change got merged and is present in the most recent nightly. Marking as ready for review so we can pick up the latest TS nightly for building VS Code |
mjbvz
approved these changes
Jul 22, 2024
sbatten
approved these changes
Jul 22, 2024
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains several updates to ensure
vscodeis forwards compatible with microsoft/TypeScript#58243, which uses a stricter return type for built-in iterators under the new strictBuiltinIteratorReturn option, which is enabled by default when building with strict.