Allow dates beyond 2038 #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The max value I calculated is of by ~7 years from what I intended it to be... |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
253202544000 = (9999 - 1970) * 365 * 24 * 60 * 60 |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 21, 2017
Summary: This diff optionally enables to skip calling rocksdb::GetApproximateSize() when FORCE INDEX is used. rocksdb::GetApproximateSize() is relatively expensive. Existing rocksdb_records_in_range variable also skips calling GetApproximateSize(), but this applies to all queries so possibilities to choose wrong index is quite high. rocksdb_force_index_records_in_range reduces the possibility. Default is 0 -- not skipping GetApproximateSize(). There are cases where accurate estimate is needed -- i.e. to decide proper join ordering or how many prefix columns to be used. So it is not possible to always skip calling GetApproximateSize(). rocksdb_force_index_records_in_range is useful when users understand their queries with FORCE INDEX don't need accurate estimated rows. Test Plan: mtr Reviewers: hermanlee4, spetrunia, jkedgar Reviewed By: jkedgar Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D52977
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 25, 2017
Summary: This diff optionally enables to skip calling rocksdb::GetApproximateSize() when FORCE INDEX is used. rocksdb::GetApproximateSize() is relatively expensive. Existing rocksdb_records_in_range variable also skips calling GetApproximateSize(), but this applies to all queries so possibilities to choose wrong index is quite high. rocksdb_force_index_records_in_range reduces the possibility. Default is 0 -- not skipping GetApproximateSize(). There are cases where accurate estimate is needed -- i.e. to decide proper join ordering or how many prefix columns to be used. So it is not possible to always skip calling GetApproximateSize(). rocksdb_force_index_records_in_range is useful when users understand their queries with FORCE INDEX don't need accurate estimated rows. Test Plan: mtr Reviewers: hermanlee4, spetrunia, jkedgar Reviewed By: jkedgar Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D52977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first go at fixing https://bugs.mysql.com/bug.php?id=12654