Added the test for HostHandler

src/main/java/com/netflix/prana/Main.java

@@ -6,6 +6,7 @@
 import com.netflix.karyon.KaryonServer;
 import com.netflix.prana.config.PranaConfig;
 import com.netflix.prana.http.api.HandlersModule;
+import com.netflix.prana.service.ServiceModule;
 import org.kohsuke.args4j.CmdLineException;
 import org.kohsuke.args4j.CmdLineParser;
 
@@ -26,7 +27,7 @@ public static void main(String args[]) {
         try {
             MainModule sm = new MainModule(pranaConfig);
             @SuppressWarnings("deprecation")
-            Injector injector = LifecycleInjector.builder().withModules(sm, new HandlersModule()).createInjector();
+            Injector injector = LifecycleInjector.builder().withModules(sm, new ServiceModule(), new HandlersModule()).createInjector();
             LifecycleManager manager = injector.getInstance(LifecycleManager.class);
             manager.start();
             KaryonServer karyonServer = injector.getInstance(KaryonServer.class);

src/main/java/com/netflix/prana/http/api/HostsHandler.java

@@ -6,6 +6,7 @@
 import com.google.inject.Inject;
 import com.netflix.appinfo.InstanceInfo;
 import com.netflix.discovery.DiscoveryClient;
+import com.netflix.prana.service.HostService;
 import io.netty.buffer.ByteBuf;
 import io.netty.handler.codec.http.HttpResponseStatus;
 import io.reactivex.netty.protocol.http.server.HttpServerRequest;
@@ -26,11 +27,11 @@ public class HostsHandler implements RequestHandler<ByteBuf, ByteBuf> {
 
     private final ObjectMapper objectMapper;
 
-    private DiscoveryClient discoveryClient;
+    private HostService hostService;
 
     @Inject
-    public HostsHandler(DiscoveryClient discoveryClient) {
-        this.discoveryClient = discoveryClient;
+    public HostsHandler(HostService hostService) {
+        this.hostService = hostService;
         this.objectMapper = new ObjectMapper();
     }
 
@@ -44,7 +45,7 @@ public Observable<Void> handle(HttpServerRequest<ByteBuf> serverRequest, HttpSer
             serverResponse.writeString("appName has to be specified");
             return serverResponse.close();
         }
-        List<InstanceInfo> instances = discoveryClient.getApplication(appName).getInstances();
+        List<InstanceInfo> instances = hostService.getHosts(appName);
         List<String> hosts = new ArrayList<>();
         for (InstanceInfo instanceInfo : instances) {
             if (vip != null && !instanceInfo.getVIPAddress().contains(vip) && instanceInfo.getStatus().equals(InstanceStatus.UP)) {

src/main/java/com/netflix/prana/service/EurekaHostService.java

@@ -0,0 +1,19 @@
+package com.netflix.prana.service;
+
+import com.netflix.appinfo.InstanceInfo;
+import com.netflix.discovery.DiscoveryClient;
+
+import java.util.List;
+
+public class EurekaHostService implements HostService {
+
+    private DiscoveryClient discoveryClient;
+
+    public EurekaHostService(DiscoveryClient discoveryClient) {
+        this.discoveryClient = discoveryClient;
+    }
+    @Override
+    public List<InstanceInfo> getHosts(String appName) {
+        return discoveryClient.getApplication(appName).getInstances();
+    }
+}

src/main/java/com/netflix/prana/service/HostService.java

@@ -0,0 +1,11 @@
+package com.netflix.prana.service;
+
+import com.google.inject.Inject;
+import com.netflix.appinfo.InstanceInfo;
+
+import java.util.List;
+
+public interface HostService {
+
+    public List<InstanceInfo> getHosts(String appName);
+}

src/main/java/com/netflix/prana/service/ServiceModule.java

@@ -0,0 +1,11 @@
+package com.netflix.prana.service;
+
+import com.google.inject.AbstractModule;
+import com.google.inject.Scopes;
+
+public class ServiceModule extends AbstractModule {
+    @Override
+    protected void configure() {
+        bind(HostService.class).to(EurekaHostService.class).in(Scopes.SINGLETON);
+    }
+}

src/test/java/com/netflix/prana/http/api/HostsHandlerTest.java

@@ -0,0 +1,62 @@
+package com.netflix.prana.http.api;
+
+import com.netflix.appinfo.InstanceInfo;
+import com.netflix.discovery.DiscoveryClient;
+import com.netflix.discovery.shared.Application;
+import com.netflix.prana.service.HostService;
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelOption;
+import io.reactivex.netty.RxNetty;
+import io.reactivex.netty.pipeline.PipelineConfigurators;
+import io.reactivex.netty.protocol.http.client.HttpClient;
+import io.reactivex.netty.protocol.http.client.HttpClientRequest;
+import io.reactivex.netty.protocol.http.server.HttpServer;
+import org.junit.*;
+
+import java.util.ArrayList;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+/**
+ * Created by dchoudhury on 10/28/14.
+ */
+public class HostsHandlerTest {
+
+    private HttpServer<ByteBuf, ByteBuf> server;
+
+    private HttpClient<ByteBuf, ByteBuf> client;
+
+    private final int port = 23455;
+
+    private HostService hostService;
+
+    @Before
+    public void setUp() {
+        hostService = mock(HostService.class);
+        ArrayList<InstanceInfo> instanceInfos = new ArrayList<>();
+        instanceInfos.add(InstanceInfo.Builder.newBuilder().setAppName("foo").setVIPAddress("bar").setHostName("host1").build());
+        instanceInfos.add(InstanceInfo.Builder.newBuilder().setAppName("foo").setVIPAddress("bar").setHostName("host2").build());
+        when(hostService.getHosts("foo")).thenReturn(instanceInfos);
+        server = RxNetty.newHttpServerBuilder(port, new HostsHandler(hostService))
+                .pipelineConfigurator(PipelineConfigurators.<ByteBuf, ByteBuf>httpServerConfigurator()).build();
+        server.start();
+        client = RxNetty.<ByteBuf, ByteBuf>newHttpClientBuilder("localhost", port)
+                .pipelineConfigurator(PipelineConfigurators.<ByteBuf, ByteBuf>httpClientConfigurator())
+                .channelOption(ChannelOption.CONNECT_TIMEOUT_MILLIS, 2000)
+                .build();
+    }
+
+    @After
+    public void tearDown() throws InterruptedException {
+        server.shutdown();
+    }
+
+    @Test
+    public void shouldReturnAListOfHostsWhenBothVipAndAppIsSpecified() {
+        HttpClientRequest<ByteBuf> request = HttpClientRequest.<ByteBuf>createGet("/hosts?appName=foo&vip=bar");
+        String response = Utils.getResponse(request, client);
+        Assert.assertEquals("[\"host1\",\"host2\"]", response);
+    }
+
+}